Date: Wed, 17 Nov 2004 20:56:42 -0800 From: John-Mark Gurney <gurney_j@resnet.uoregon.edu> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_sk.c Message-ID: <20041118045642.GS57546@funkthat.com> In-Reply-To: <20041117224336.GC1562@ip.net.ua> References: <200411172135.iAHLZNfR098453@repoman.freebsd.org> <20041117224336.GC1562@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov wrote this message on Thu, Nov 18, 2004 at 00:43 +0200:
> My old patch (that I didn't commit due to the lack of h/w),
> resets IFF_OACTIVE inside the while() loop, like this:
>
> sc_if->sk_cdata.sk_tx_cnt--;
> + ifp->if_flags &= ~IFF_OACTIVE;
> SK_INC(idx, SK_TX_RING_CNT);
>
> I believe this is more correct than what got committed,
> but I cannot prove it. ;)
considering that we hold the lock over the while loop, and then call
sk_start before the lock gets unlocked... :)
I have a similar patch for if_re that I need to try out...
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041118045642.GS57546>