Date: Fri, 3 May 2002 03:31:49 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Dima Dorfman <dima@trit.org> Cc: Warner Losh <imp@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/conf kmod.mk Message-ID: <20020503032719.G4775-100000@gamplex.bde.org> In-Reply-To: <20020501235744.ACE123F71@turbine.trit.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 1 May 2002, Dima Dorfman wrote:
> Warner Losh <imp@FreeBSD.org> wrote:
> > Log:
> > We don't need no stinkin' echos here.
> ...
> > Index: src/sys/conf/kmod.mk
> > diff -u src/sys/conf/kmod.mk:1.122 src/sys/conf/kmod.mk:1.123
> > --- src/sys/conf/kmod.mk:1.122 Tue Apr 30 20:28:14 2002
> > +++ src/sys/conf/kmod.mk Wed May 1 12:24:26 2002
> > @@ -170,6 +170,9 @@
> > .endif
> > .endif
> >
> > +.if !exists(/usr/sbin/kldxref)
> > +NO_XREF=yes
> > +.endif
This is broken. kldxref might be in $PATH but not in /usr/sbin, or vice
versa.
> >
> > _ILINKS=@ machine
> >
> > @@ -257,9 +260,7 @@
> > done; true
> > .endif
> > .if !defined(NO_XREF)
If a non-broken existence test ifdef exists, why not write it here directly.
> > - @echo "FAILURES HERE ARE OK"
> > -kldxref ${DESTDIR}${KMODDIR}
>
> Since we don't get here when kldxref doesn't exist any more, shouldn't
> we get rid of the '-'? I.e., make the last line read:
>
> kldxref ${DESTDIR}${KMODDIR}
>
> Or are their other failure modes we want to ignore?
I agree. Ignoring errors in Makefiles is a bug.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020503032719.G4775-100000>