Date: Wed, 28 Feb 2007 03:12:05 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: doconnor@gsoft.com.au Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/usb umass.c Message-ID: <20070228.031205.-1303465006.imp@bsdimp.com> In-Reply-To: <200702281302.18223.doconnor@gsoft.com.au> References: <200702272233.l1RMXocb004983@repoman.freebsd.org> <200702281302.18223.doconnor@gsoft.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200702281302.18223.doconnor@gsoft.com.au> "Daniel O'Connor" <doconnor@gsoft.com.au> writes: : On Wednesday 28 February 2007 09:03, Warner Losh wrote: : > Create a new quirk READ_CAPACITY_OFFBY1 and add a quirk for the : > SanDISK ImageMate that I have that suffers from this problem (the : > SDDR-31). It intercepts the READ_CAPACITY response and adjusts it : > from number of sectors to max sector for devices with this quirk. : > : > Reading the Linux source suggests that there are a host of : > other devices with this issue, including iPods and some popular : > cameras. I've not added quirks for them, since I don't have the : > devices in front of me to test. : : Couldn't you automatically test for this? ie try and read the last sector. : : Obviously if there is a real error in the last sector you'd get a bogus result : but I don't think that is likely to be very common :) To amplify my last answer: No. I couldn't automatically test for this. Others can submit patches if they want it. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070228.031205.-1303465006.imp>