Date: Mon, 17 Jan 2011 21:20:08 GMT From: Juergen Lock <nox@jelal.kn-bremen.de> To: freebsd-net@FreeBSD.org Subject: Re: kern/153938: [run] [panic] [patch] Workaround for use-after-free panic Message-ID: <201101172120.p0HLK8iN009772@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/153938; it has been noted by GNATS. From: Juergen Lock <nox@jelal.kn-bremen.de> To: PseudoCylon <moonlightakkiy@yahoo.ca> Cc: Juergen Lock <nox@jelal.kn-bremen.de>, bug-followup@freebsd.org Subject: Re: kern/153938: [run] [panic] [patch] Workaround for use-after-free panic Date: Mon, 17 Jan 2011 22:14:04 +0100 On Sun, Jan 16, 2011 at 10:24:07PM -0800, PseudoCylon wrote: > > [...] > > I see you removed the rn->wcid code, I guess I should have > > explained what it's for: ni->ni_associd already gets zeroed before > > run_node_cleanup() is called so with your version no sc->sc_ni[wcid] > > ever gets set to NULL. > > > > You're right. > > > + if (wcid == 0) > > + wcid = rn->wcid; > > > Is there any reason to test "ni->ni_associd == 0"? We know it is 0. Oh I only left it in in case the surrounding code changes in the future, but I guess that's pretty unlikely. So I agree the check can be removed...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101172120.p0HLK8iN009772>