Date: 11 Mar 2002 00:17:27 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: David Malone <dwmalone@maths.tcd.ie> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_linker.c Message-ID: <1015798536.527.38.camel@notebook> In-Reply-To: <20020310202940.GA94559@walton.maths.tcd.ie> References: <200203101920.g2AJK1B38135@freefall.freebsd.org> <20020310202940.GA94559@walton.maths.tcd.ie>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, 2002-03-10 at 22:29, David Malone wrote: > On Sun, Mar 10, 2002 at 11:20:01AM -0800, Maxim Sobolev wrote: > > sobomax 2002/03/10 11:20:01 PST > > > > Modified files: > > sys/kern kern_linker.c > > Log: > > Fix a breakage introduced in rev.1.75 (supposedly style cleanup), which results > > in "missing dependencies" error when loading some kld modules. It is sad to > > see how often these days style cleanus break doesn't broken things. Perhaps > > people should recall good old principle: "don't fix it if it isn't broken". > > Maxim, > > Would you mind if I chaned all the "err = strcmp() if (err == 0)"s > in this file into "if (strcmp() == 0)". The fix I proposed in the > PR mentioned by Steven did this (it fixed the same bug and made the > strcmps a little more sane). Yeah, please do. -Maxim [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQA8i9sIoNu5t4iCBa8RApdOAJ0QPeuRt/4qAOUz2ZZsggkyakMu0gCfac9m F69I9lRpnH+yGsThW0ktMe8= =79cW -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1015798536.527.38.camel>