Date: Mon, 20 Mar 2006 07:50:50 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Doug Barton <dougb@freebsd.org> Cc: ports@freebsd.org, Ceri Davies <ceri@submonkey.net>, doc@freebsd.org, Alfred Morgan <alfred.morgan@experclick.com> Subject: Re: update document Message-ID: <20060320155050.GA18306@odin.ac.hmc.edu> In-Reply-To: <441E657C.1040209@FreeBSD.org> References: <C0435540.ADB4%ceri@submonkey.net> <441E657C.1040209@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--k1lZvvs/B4yU6o8G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 20, 2006 at 12:19:08AM -0800, Doug Barton wrote: > Ceri Davies wrote: > > On 15/3/06 19:15, "Alfred Morgan" <alfred.morgan@experclick.com> wrote: > >=20 > >> In this document: > >> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-s= cripts.h > >> tml > >> > >> Can we change: > >> > >> rcvar=3D${name}_enable > >> > >> to be : > >> > >> rcvar=3D`set_rcvar` > >> > >> so that it would be a good example how to be other OS (OpenBSD) > >> compatible as well. >=20 > The set_rcvar function simply returns ${name}_enable, so setting that val= ue > explicitly in the example removes a layer of indirection, and helps make = it > more clear what's happening there, which makes it a better example. I disagree unless we're planning to deprecate set_rcvar. Either we should always use it in new scripts (and thus in examples) or get rid of it. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --k1lZvvs/B4yU6o8G Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFEHs9ZXY6L6fI4GtQRAjCoAJ9gdO2k1k0NKYJGsPfN44AHxy8/CgCg5Pse 5IqAOO3VZeq7Y4vz7tvXWUA= =q3PD -----END PGP SIGNATURE----- --k1lZvvs/B4yU6o8G--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060320155050.GA18306>