Date: Mon, 18 Sep 2000 10:59:19 +0200 (CEST) From: Alexander Leidinger <Alexander@Leidinger.net> To: jdp@polstra.com Cc: current@freebsd.org Subject: Re: patch for openssh Message-ID: <200009180859.e8I8xKn01498@Magelan.Leidinger.net> In-Reply-To: <200009172039.NAA12052@vashon.polstra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17 Sep, John Polstra wrote:
> What is the point of that change? Functionally it makes no difference
> at all, since "*auth" is an AuthenticationConnection. It makes the
I was a little bit confused at that time. Yes, it's more of a bikeshed
decision, IMHO it makes it less difficult to read (you didn't have to
search for the type).
> code harder to maintain in case the type of "auth" is changed in the
> future.
This depends on the type of change someone makes. If you didn't change
the typedef of "AuthenticationConnection" but the type of "auth", you
normaly have to go through the code and ensure every invariant is still
valid (I classify this as a major code change, but this is a bikeshed
argument too).
Bye,
Alexander.
--
The three Rs of Microsoft support: Retry, Reboot, Reinstall.
http://www.Leidinger.net Alexander @ Leidinger.net
GPG fingerprint = 7423 F3E6 3A7E B334 A9CC B10A 1F5F 130A A638 6E7E
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200009180859.e8I8xKn01498>