Date: Sat, 7 Oct 2017 13:04:09 -0700 (PDT) From: Don Lewis <truckman@FreeBSD.org> To: kib@FreeBSD.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r324313 - head/sys/amd64/amd64 Message-ID: <201710072004.v97K49xE062415@gw.catspoiler.org> In-Reply-To: <201710051250.v95Co31e048931@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5 Oct, Konstantin Belousov wrote: > Author: kib > Date: Thu Oct 5 12:50:03 2017 > New Revision: 324313 > URL: https://svnweb.freebsd.org/changeset/base/324313 > > Log: > Avoid a race betweem freeing LDT and context switches. > > cpu_switch.S uses curproc->p_md.md_ldt value as the flag indicating > presence of the process LDT. The flag is checked and then ldt segment > descriptor is copied into the CPU' GDT slot. > > Disallow context switches around clearing of the curproc LDT state by > performing the cleanup in critical section. Ensure that the md_ldt > flag is cleared before md_ldt_sd descriptor content is destroyed by > inserting fence between the operations. > > We depend on the x86 memory model strong ordering guarantees, in > particular, that cpu_switch.S observes the writes to md_ldt and > md_ldt_sd in the expected order. I don't know which of this series of commits is responsible, but I think that it fixed the build of lang/ghc on Ryzen. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221029#c102
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201710072004.v97K49xE062415>