Date: Fri, 23 Dec 2011 13:55:14 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Aleksandr Rybalko <ray@freebsd.org> Cc: embedded@freebsd.org, Stefan Bethke <stb@lassitu.de> Subject: Re: geom_uncompress Message-ID: <CAJ-VmomXNa=gb0GmXd4vxNZ8-uWUJqAPETehMqKJcG9zGL3ddg@mail.gmail.com> In-Reply-To: <20111223173139.dd31e9cb.ray@freebsd.org> References: <20111223122947.4235c390.ray@freebsd.org> <1C7BEB2A-E3DE-4AB0-BC57-AC0025116EF0@lassitu.de> <20111223173139.dd31e9cb.ray@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Some more of my comments: * We can do a pass later on to integrate this stuff into the kernel better, including using a single crc32 function. * The style seems quite fine, except the '?0:1' bits - can you please expand that out with spaces and put them on a new line (as they're already pushing up against 78 characters) I really don't like the cute hack of "sh image.uzlma". :) The main problem I have with it is it really is only appropriate if you're mounting things as a R/O cd9660 format, and totally silly otherwise. Can we possibly remove that for now, and maybe you can add that as a "vendor customisation" in zrouter somehow? (eg creating another flag in the magic header or something?) Other than that, I'm happy to commit this whole thing to FreeBSD and sort out the mess after that. Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomXNa=gb0GmXd4vxNZ8-uWUJqAPETehMqKJcG9zGL3ddg>