Date: Fri, 14 Apr 2017 19:49:20 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: rgrimes@freebsd.org Cc: John Baldwin <jhb@freebsd.org>, Ngie Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316938 - head/sbin/savecore Message-ID: <62071184-0DDD-4996-867E-866BF1F8DC25@gmail.com> In-Reply-To: <4CBF25DF-F407-4F50-8724-B73F64734E19@gmail.com> References: <201704150149.v3F1nu0D009274@pdx.rh.CN85.dnsmgr.net> <4CBF25DF-F407-4F50-8724-B73F64734E19@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_7EEE690C-291E-4F6A-BEAF-F17DAD12193F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 14, 2017, at 19:40, Ngie Cooper (yaneurabeya) = <yaneurabeya@gmail.com> wrote: >=20 >>=20 >> On Apr 14, 2017, at 18:49, Rodney W. Grimes = <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: >>=20 >>> On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: >>>> Author: ngie >>>> Date: Fri Apr 14 19:41:48 2017 >>>> New Revision: 316938 >>>> URL: https://svnweb.freebsd.org/changeset/base/316938 >>>>=20 >>>> Log: >>>> savecore: fix space calculation with respect to `minfree` in = check_space(..) >>>>=20 >>>> - Use strtoll(3) instead of atoi(3), because atoi(3) limits the >>>> representable data to INT_MAX. Check the values received from >>>> strtoll(3), trimming trailing whitespace off the end to maintain >>>> POLA. >>>> - Use `KiB` instead of `kB` when describing free space, total = space, >>>> etc. I am now fully aware of `KiB` being the IEC standard for = 1024 >>>> bytes and `kB` being the IEC standard for 1000 bytes. >>>=20 >>> I will just rant lightly that no one actually uses this in the real = world. >>>=20 >>> Good lucking finding a "16 GiB" DIMM on crucial.com or a 4Kin drive. = A >>> kilobyte is a power of 2. The End. >>>=20 >>> (Next up we'll have to rename 4k displays to >>> 4k<insert arbitrary and unrelated letter here>) >>=20 >> Do we use KiB, MiB, GiB,... any place else in the system? I cant = think of >> a place we do this, so please, lets not start doing this here? >=20 > humanize_number(3) from libutil uses IEC units. >=20 >> Yes, these are newer standards, perhaps some day we should make a = global >> switch to them, but lets not start mixing and matching things. >=20 > I understand and agree. I=E2=80=99m not 100% sold on that one way or = another, but since I was going to redo the number representation in save = core with humanize_number(3), because reading `<really-long-int>KiB` is = not ideal usability wise, and I don=E2=80=99t want to reinvent the wheel = normalizing numbers and printing out the unit. *unit. =E2=80=94> *unit, KiB seemed like a logical next step after = discussing it at long length in the CR. -Ngie --Apple-Mail=_7EEE690C-291E-4F6A-BEAF-F17DAD12193F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8YowAAoJEPWDqSZpMIYVdU0QAMtoqa/sNeFe4pWmE4zMlH7C phHTNmNrYYGi7Uy0y0FoD7QsXW50JnBMK/EzpaEsZ5qZcJVHUwgGbzQChfcYtYNg lb57F8ma3RG/bQbXfgoNS5vhVUQeqJXUW/6S3/eRJxpnHck7okncs850ON0zyX+s jXEEbV2n6MiqwPkfpWE61h7H6IbNao1rxa4qfZtuIkne+ZmGZ85VR3F0ufAnu8ab g0b0Jf7+LtZCf6f50242kUa/g4y2u9J/3l8fqlA+jxj5kgmwwdSw6x35J9cqtgmV SpOz5SxBhLwIV2xKBwB544KDivL4u6HsO3vVLWVZxzX2xRDN7U574GlUlOeoON2p me3KON4lkKi+mv+2S2K6tYnSQHg61SSlMpF1yI/ncG2s1UW8Cq1H7sX/icQ1Gw9B Lu717C1gKVPN2liKVudUzpWOdnvPlnliyiE2FT6THtuwQtpnlHHavTkKaUfnoldX zaiq+yGt/XqmTN2Uaga1GJiPpGJML8bAZW8lGr1x2yis/8yXfXQDLb8BzR2yfQ4D 1BGWl0VB9MdXPKttELz4J+Y2sI4goO0LKZcg7W8Nf0ygrVl6iP3n6ZUI5GWXJ8LH 4SCWreJ3ieEq/sTwA/MmX3nXNAJafJL8gSalvMPoj0w033QIyMqwvkIUu3YNq0G1 wBTKgZ0kqId6hDlZJJu1 =qfu7 -----END PGP SIGNATURE----- --Apple-Mail=_7EEE690C-291E-4F6A-BEAF-F17DAD12193F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?62071184-0DDD-4996-867E-866BF1F8DC25>