Date: Sun, 20 Jan 2019 23:12:59 -0500 From: Mark Johnston <markj@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343247 - head/usr.bin/cmp/tests Message-ID: <20190121041259.GB96979@raichu> In-Reply-To: <D2A1CF1D-E5BE-4FB0-A1AE-855F0E959495@gmail.com> References: <201901210357.x0L3vnIx052453@repo.freebsd.org> <6CF2AD75-F267-4E1F-8505-605BB468D5AF@gmail.com> <D2A1CF1D-E5BE-4FB0-A1AE-855F0E959495@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 20, 2019 at 08:11:20PM -0800, Enji Cooper wrote: > > > On Jan 20, 2019, at 8:10 PM, Enji Cooper <yaneurabeya@gmail.com> wrote: > > > > > >> On Jan 20, 2019, at 7:57 PM, Mark Johnston <markj@FreeBSD.org> wrote: > >> > >> Author: markj > >> Date: Mon Jan 21 03:57:49 2019 > >> New Revision: 343247 > >> URL: https://svnweb.freebsd.org/changeset/base/343247 > >> > >> Log: > >> Fix cmp(1) tests for "special" mode. > >> > >> Test failures don't seem to propagate up if atf_check is run in > >> a pipeline. Thus, the tests continued to pass despite the bug reverted > >> in r343245. > > > > Hmmm… that’s strange… > > -Enji > > There’s a good chance that this issue is also masked by the fact that the CI runs have been panicking with bug 235097 as well. > Cheers, > -Enji No, I ran the tests locally before committing the now-reverted diff.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190121041259.GB96979>