Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 May 2003 02:27:27 -0700
From:      Terry Lambert <tlambert2@mindspring.com>
To:        David Xu <davidxu@freebsd.org>
Cc:        freebsd-current@freebsd.org
Subject:   Re: panic: kern/52718
Message-ID:  <3ED723FF.CBF45577@mindspring.com>
References:  <20030529164240.X769@gravy.homeunix.net> <3ED71E39.A0F8EBC3@mindspring.com> <000701c3268b$86faaa30$f001a8c0@davidw2k>

next in thread | previous in thread | raw e-mail | index | archive | help
David Xu wrote:
> > This was caused by rev. 1.3 of a commit by Jeff Robertson to
> > kern_utmx.c.  The problem is that the proc struct is not locked
> > for:
> >
> >         FOREACH_THREAD_IN_PROC(td->td_proc, td0)
> >
> > in the lock and unlock.
> >
> > Either lock the proc before and unlock it after this, in both
> > _utmx_lock() and _utmx_unlock(), or revert the code to 1.2.
> 
> kern_sig.c has same issue in several places.

Just looked... YUCK!  The Process group code and the code in
the filt_sigdetach() have got to be what you are talking about,
right?

I'm constantly surprised at some of the race windows I find in
production code (not just FreeBSD), that are just waiting there
to chew someone's leg off the first chance they get... 8-(.

-- Terry



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3ED723FF.CBF45577>