Date: Thu, 22 Feb 2018 23:13:57 +0000 From: "grehan (Peter Grehan)" <phabric-noreply@FreeBSD.org> To: freebsd-virtualization@freebsd.org Subject: [Differential] D14473: userboot: add callbacks to set unrestricted guest mode Message-ID: <5af862fd1312906bb2137a17b388c964@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-z4kdgdlru2lrsvfkw4bo-req@FreeBSD.org> References: <differential-rev-PHID-DREV-z4kdgdlru2lrsvfkw4bo-req@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
grehan added inline comments.
INLINE COMMENTS
> bhyveload.c:566
> +{
> + return (vm_get_capability(ctx, vcpu,
> + VM_CAP_UNRESTRICTED_GUEST, retval));
Minor style(9) - should be an empty line before the rreturn - see the routine above.
> bhyveload.c:567
> + return (vm_get_capability(ctx, vcpu,
> + VM_CAP_UNRESTRICTED_GUEST, retval));
> +}
Minor style(9) - continued lines should be indented by 4 spaces.
> bhyveload.c:574
> + int error, tmp;
> + if ((error = cb_vm_get_unrestricted_guest(arg, vcpu, &tmp)))
> + return error;
Minor style(9) - blank line between declarations and statement.
> bhyveload.c:575
> + if ((error = cb_vm_get_unrestricted_guest(arg, vcpu, &tmp)))
> + return error;
> +
Minor style(9) - return expression should be enclosed in parens.
> bhyveload.c:584
> +{
> + return vcpu_reset(ctx, vcpu);
> +}
Minor style(9) - blank line needed before statement, and return expression should be in parens.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D14473
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: fabian.freyer_physik.tu-berlin.de, imp, #bhyve, grehan
Cc: grehan, imp, freebsd-virtualization-list, #contributor_reviews_base
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5af862fd1312906bb2137a17b388c964>