Date: Sat, 22 Feb 2014 07:00:01 GMT From: Robert Sevat <robert.sevat@live.nl> To: freebsd-ports-bugs@FreeBSD.org Subject: RE: ports/186865: [patch] change rc.d script for security/strongswan Message-ID: <201402220700.s1M701JF079011@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/186865; it has been noted by GNATS.
From: Robert Sevat <robert.sevat@live.nl>
To: "bug-followup@FreeBSD.org" <bug-followup@freebsd.org>,
"jason.unovitch@gmail.com" <jason.unovitch@gmail.com>
Cc:
Subject: RE: ports/186865: [patch] change rc.d script for security/strongswan
Date: Sat, 22 Feb 2014 07:51:01 +0100
--_7ada49d0-1371-4c15-bc89-3584d39d4624_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Hey Jason=2C
I've tested your changes to the rc script and it works as it is supposed to=
.
Kind Regards=2C
Robert Sevat
> Date: Thu=2C 20 Feb 2014 21:11:01 -0500
> From: jason.unovitch@gmail.com
> To: robert.sevat@live.nl
> CC: bug-followup@FreeBSD.org
> Subject: Re: ports/186865: [patch] change rc.d script for security/strong=
swan
>=20
> Robert=2C
> There's actually a few things that can use some tweaking per RC lint. =20
> I've attached a fixed version of the RC script for you to try along with=
=20
> a patch that fixes the first 4 of the RC lint issues. It makes sense to=
=20
> me as the one-line function results in much less clutter above but the=20
> maintainer/committer can decide on exactly what do do with that.
>=20
> RC Lint before:
> Checking strongswan
> ERROR:root:[0]: Order of rc file incorrect
> ERROR:root:[0]: Order of variables incorrect
> ERROR:root:[13]: Do not quote values unless necessary
> ERROR:root:[14]: rcvar is not set correctly
> ERROR:root:[27]: One-line functions discouraged=3B put command directly i=
n=20
> variable
>=20
> RC Lint after:
> Checking strongswan
> ERROR:root:[27]: One-line functions discouraged=3B put command directly i=
n=20
> variable
>=20
> Jason
=
--_7ada49d0-1371-4c15-bc89-3584d39d4624_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<style><!--
.hmmessage P
{
margin:0px=3B
padding:0px
}
body.hmmessage
{
font-size: 12pt=3B
font-family:Calibri
}
--></style></head>
<body class=3D'hmmessage'><div dir=3D'ltr'>Hey Jason=2C<br><br>I've tested =
your changes to the rc script and it works as it is supposed to.<br><br>Kin=
d Regards=2C<br><br>Robert Sevat<br><br><br><div>>=3B Date: Thu=2C 20 Feb=
2014 21:11:01 -0500<br>>=3B From: jason.unovitch@gmail.com<br>>=3B To:=
robert.sevat@live.nl<br>>=3B CC: bug-followup@FreeBSD.org<br>>=3B Subj=
ect: Re: ports/186865: [patch] change rc.d script for security/strongswan<b=
r>>=3B <br>>=3B Robert=2C<br>>=3B There's actually a few things that =
can use some tweaking per RC lint. <br>>=3B I've attached a fixed versio=
n of the RC script for you to try along with <br>>=3B a patch that fixes =
the first 4 of the RC lint issues. It makes sense to <br>>=3B me as the =
one-line function results in much less clutter above but the <br>>=3B mai=
ntainer/committer can decide on exactly what do do with that.<br>>=3B <br=
>>=3B RC Lint before:<br>>=3B Checking strongswan<br>>=3B ERROR:root:=
[0]: Order of rc file incorrect<br>>=3B ERROR:root:[0]: Order of variable=
s incorrect<br>>=3B ERROR:root:[13]: Do not quote values unless necessary=
<br>>=3B ERROR:root:[14]: rcvar is not set correctly<br>>=3B ERROR:root=
:[27]: One-line functions discouraged=3B put command directly in <br>>=3B=
variable<br>>=3B <br>>=3B RC Lint after:<br>>=3B Checking strongswan=
<br>>=3B ERROR:root:[27]: One-line functions discouraged=3B put command d=
irectly in <br>>=3B variable<br>>=3B <br>>=3B Jason<br></div> =
</div></body>
</html>=
--_7ada49d0-1371-4c15-bc89-3584d39d4624_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402220700.s1M701JF079011>