Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Jan 2025 18:08:32 GMT
From:      Olivier Certner <olce@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: eed08497de05 - stable/14 - syscallsubr.h: Header inclusions: Explicit <sys/param.h>, sort
Message-ID:  <202501161808.50GI8WWs092579@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by olce:

URL: https://cgit.FreeBSD.org/src/commit/?id=eed08497de05a3ab6bbdb3823aafccd82e161996

commit eed08497de05a3ab6bbdb3823aafccd82e161996
Author:     Olivier Certner <olce@FreeBSD.org>
AuthorDate: 2024-12-02 15:06:29 +0000
Commit:     Olivier Certner <olce@FreeBSD.org>
CommitDate: 2025-01-16 18:07:00 +0000

    syscallsubr.h: Header inclusions: Explicit <sys/param.h>, sort
    
    <sys/types.h> is currently brought in by other headers but some of its
    type definition are directly used in this header, so it should appear
    explicitly.  It is necessary as lots of prototypes in there use types it
    defines (<sys/_types.h> wouldn't be enough).
    
    Additionally, <sys/_cpuset.h> and <sys/_domainset.h> need constants from
    <machine/param.h>, so just include <sys/param.h> instead of
    <sys/types.h>.
    
    Sort header inclusions as per style(9).
    
    No functional change (intended).
    
    Approved by:    markj (mentor)
    MFC after:      5 days
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D47881
    
    (cherry picked from commit 8cdb0458e12e6fac577cfb2277e7e85d3c21fa09)
---
 sys/sys/syscallsubr.h | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/sys/sys/syscallsubr.h b/sys/sys/syscallsubr.h
index b3ba50823e93..52d2035cc962 100644
--- a/sys/sys/syscallsubr.h
+++ b/sys/sys/syscallsubr.h
@@ -28,13 +28,14 @@
 #ifndef _SYS_SYSCALLSUBR_H_
 #define _SYS_SYSCALLSUBR_H_
 
-#include <sys/signal.h>
-#include <sys/socket.h>
-#include <sys/mac.h>
-#include <sys/mount.h>
+#include <sys/param.h>
 #include <sys/_cpuset.h>
 #include <sys/_domainset.h>
 #include <sys/_uio.h>
+#include <sys/mac.h>
+#include <sys/mount.h>
+#include <sys/signal.h>
+#include <sys/socket.h>
 
 struct __wrusage;
 struct cpuset_copy_cb;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202501161808.50GI8WWs092579>