Date: Wed, 27 Feb 2019 15:43:47 -0600 From: Eric van Gyzen <eric@vangyzen.net> To: Warner Losh <imp@bsdimp.com> Cc: Alexey Dokuchaev <danfe@freebsd.org>, "Rodney W. Grimes" <rgrimes@freebsd.org>, "Simon J. Gerraty" <sjg@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r344567 - in head: etc/mtree include sbin sbin/veriexec Message-ID: <93571A02-D75D-47AB-981F-5312D4B6BEDD@vangyzen.net> In-Reply-To: <CANCZdfq=QWCxLV5UjgNGmC6ZuZiPTXZ8bn%2BNjYyjQ-QaK6twsA@mail.gmail.com> References: <201902260617.x1Q6HOra098699@repo.freebsd.org> <201902260619.x1Q6Jjn2043418@pdx.rh.CN85.dnsmgr.net> <20190226134953.GB39566@FreeBSD.org> <CANCZdfq=QWCxLV5UjgNGmC6ZuZiPTXZ8bn%2BNjYyjQ-QaK6twsA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 26, 2019, at 10:17 PM, Warner Losh <imp@bsdimp.com> wrote: >=20 >=20 >=20 > On Tue, Feb 26, 2019, 6:50 AM Alexey Dokuchaev <danfe@freebsd.org = <mailto:danfe@freebsd.org>> wrote: > On Mon, Feb 25, 2019 at 10:19:45PM -0800, Rodney W. Grimes wrote: > > > Author: sjg > > > Date: Tue Feb 26 06:17:23 2019 > > > New Revision: 344567 > > > URL: https://svnweb.freebsd.org/changeset/base/344567 = <https://svnweb.freebsd.org/changeset/base/344567>; > > >=20 > > > Log: > > > Add verifying manifest loader for mac_veriexec > > > =20 > > > This tool will verify a signed manifest and load contents into > > > mac_veriexec for storage > > > =20 > > > Sponsored by: Juniper Networks > > > Differential Revision: D16575 > >=20 > > Just a small nit, for future reference, from the template: > > > Differential Revision: https://reviews.freebsd.org/D### = <https://reviews.freebsd.org/D#%23%23>; > > (*full* phabric URL needed). >=20 > IMHO we should just fix the scripts to accept D#### alone, without > the URL. We don't do that for PR (bugzilla) references, and the fact > that we do for the phab is both needless and confusing. Also, that > URL might change one day while we could probably keep the old numbers > if we move. >=20 > When this came up before, it was an upstream decision to require the = full path. The reasoning is that Dxxxx space isn't unique and the review = may happen in a different instance of phab than the default one. When = those exact objections were raised, the experience of moving to bugzilla = was cited to show the URL can remain stable. And if we went to another = system's, we could keep the old in place and then we would need a new = URL to disambiguate. There were good reasons we decided this before. >=20 > So this has been litigated before, and the consensus was we needed to = break with the practice of not putting URLs in commit messages for these = reasons. I completely agree. In fact, I=E2=80=99d like to see full bugzilla URLs = in commit logs instead of just the bug number. Every app I use to read = commit logs will make URLs clickable, even my terminal emulator. The = fact that I have to manually open bugzilla and copy/type the bug number = is annoying. And yes, I volunteer to make the necessary changes to accept URLs in the = PR field. We just need consensus. Eric=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?93571A02-D75D-47AB-981F-5312D4B6BEDD>