Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 9 Dec 2022 14:11:06 GMT
From:      Cy Schubert <cy@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 5319949668a5 - main - Revert "heimdal: Fix bus fault when zero-length request received"
Message-ID:  <202212091411.2B9EB629052860@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by cy:

URL: https://cgit.FreeBSD.org/src/commit/?id=5319949668a5cb4d182d7252ce26799506b3585d

commit 5319949668a5cb4d182d7252ce26799506b3585d
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-12-08 16:08:50 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-12-09 14:09:54 +0000

    Revert "heimdal: Fix bus fault when zero-length request received"
    
    This is the wrong fix for PR/268062.
    
    MFC after:      immediately
    
    This reverts commit 6742ff42ab3b6e65239f975314060b1393e22d62.
---
 crypto/heimdal/lib/krb5/read_message.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/crypto/heimdal/lib/krb5/read_message.c b/crypto/heimdal/lib/krb5/read_message.c
index e994b0f09133..4e9bd012dd67 100644
--- a/crypto/heimdal/lib/krb5/read_message.c
+++ b/crypto/heimdal/lib/krb5/read_message.c
@@ -55,11 +55,6 @@ krb5_read_message (krb5_context context,
 	return HEIM_ERR_EOF;
     }
     len = (buf[0] << 24) | (buf[1] << 16) | (buf[2] << 8) | buf[3];
-    if (len == 0) {
-	krb5_clear_error_message(context);
-	return HEIM_ERR_EOF;
-    }
-
     ret = krb5_data_alloc (data, len);
     if (ret) {
 	krb5_clear_error_message(context);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202212091411.2B9EB629052860>