Date: Tue, 23 May 2000 11:52:06 +0400 (MSD) From: Oleg Sharoiko <os@rsu.ru> To: freebsd-hackers@FreeBSD.ORG Subject: Bug in advansys driver Message-ID: <Pine.BSF.4.10.10005231137570.86096-200000@altos.rsu.ru>
next in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-1518726426-959068326=:86096 Content-Type: TEXT/PLAIN; charset=US-ASCII Hello! It seems that during porting to newbus architecture adv_attach was left unchanged and current version (I mean the current version of -STABLE sources, I didn't check -CURRENT) returns incorrect values (1 on success, 0 in all other cases). I've fixed this, the patch is in the attached file. I'm not sure that I put correct error codes for all cases so I think it would be good if someone looks through it. Anyway this code works (at least for me) and -STABLE sources don't. Hope this small work will be useful. -- Oleg Sharoiko. Computer Center of Rostov State University. --0-1518726426-959068326=:86096 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="advansys.diff" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.BSF.4.10.10005231152060.86096@altos.rsu.ru> Content-Description: Content-Disposition: attachment; filename="advansys.diff" SW5kZXg6IGFkdmFuc3lzLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJD UyBmaWxlOiAvdXNyL2N2cy9GcmVlQlNEL3NyYy9zeXMvZGV2L2FkdmFuc3lz L2FkdmFuc3lzLmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjE0LjIuMQ0K ZGlmZiAtdSAtcjEuMTQuMi4xIGFkdmFuc3lzLmMNCi0tLSBhZHZhbnN5cy5j CTIwMDAvMDQvMTQgMTM6MzI6NDcJMS4xNC4yLjENCisrKyBhZHZhbnN5cy5j CTIwMDAvMDUvMjMgMDc6MjE6MzQNCkBAIC0xMzAzLDcgKzEzMDMsNyBAQA0K IAkJCQlNX0RFVkJVRiwgTV9OT1dBSVQpOw0KIA0KIAlpZiAoYWR2LT5jY2Jf aW5mb3MgPT0gTlVMTCkNCi0JCWdvdG8gZXJyb3JfZXhpdDsNCisJCXJldHVy biAoRU5PTUVNKTsNCiANCiAJYWR2LT5pbml0X2xldmVsKys7DQogCQkNCkBA IC0xMzQ1LDcgKzEzNDUsNyBAQA0KIAkJCSAgICAgICAvKm1heHNlZ3N6Ki9C VVNfU1BBQ0VfTUFYU0laRV8zMkJJVCwNCiAJCQkgICAgICAgLypmbGFncyov QlVTX0RNQV9BTExPQ05PVywNCiAJCQkgICAgICAgJmFkdi0+YnVmZmVyX2Rt YXQpICE9IDApIHsNCi0JCWdvdG8gZXJyb3JfZXhpdDsNCisJCXJldHVybiAo RU5YSU8pOw0KIAl9DQogCWFkdi0+aW5pdF9sZXZlbCsrOw0KIA0KQEAgLTEz NTgsNyArMTM1OCw3IEBADQogCQkJICAgICAgIC8qbnNlZ21lbnRzKi8xLA0K IAkJCSAgICAgICAvKm1heHNlZ3N6Ki9CVVNfU1BBQ0VfTUFYU0laRV8zMkJJ VCwNCiAJCQkgICAgICAgLypmbGFncyovMCwgJmFkdi0+c2Vuc2VfZG1hdCkg IT0gMCkgew0KLQkJZ290byBlcnJvcl9leGl0Ow0KKwkJcmV0dXJuIChFTlhJ Tyk7DQogICAgICAgICB9DQogDQogCWFkdi0+aW5pdF9sZXZlbCsrOw0KQEAg LTEzNjYsNyArMTM2Niw3IEBADQogCS8qIEFsbG9jYXRpb24gZm9yIG91ciBz ZW5zZSBidWZmZXJzICovDQogCWlmIChidXNfZG1hbWVtX2FsbG9jKGFkdi0+ c2Vuc2VfZG1hdCwgKHZvaWQgKiopJmFkdi0+c2Vuc2VfYnVmZmVycywNCiAJ CQkgICAgIEJVU19ETUFfTk9XQUlULCAmYWR2LT5zZW5zZV9kbWFtYXApICE9 IDApIHsNCi0JCWdvdG8gZXJyb3JfZXhpdDsNCisJCXJldHVybiAoRU5PTUVN KTsNCiAJfQ0KIA0KIAlhZHYtPmluaXRfbGV2ZWwrKzsNCkBAIC0xMzg1LDcg KzEzODUsNyBAQA0KIAlpZiAoYWR2X3N0YXJ0X2NoaXAoYWR2KSAhPSAxKSB7 DQogCQlwcmludGYoImFkdiVkOiBVbmFibGUgdG8gc3RhcnQgb24gYm9hcmQg cHJvY2Vzc29yLiBBYm9ydGluZy5cbiIsDQogCQkgICAgICAgYWR2LT51bml0 KTsNCi0JCXJldHVybiAoMCk7DQorCQlyZXR1cm4gKEVOWElPKTsNCiAJfQ0K IA0KIAkvKg0KQEAgLTEzOTMsNyArMTM5Myw3IEBADQogCSAqLw0KIAlkZXZx ID0gY2FtX3NpbXFfYWxsb2MoYWR2LT5tYXhfb3BlbmluZ3MpOw0KIAlpZiAo ZGV2cSA9PSBOVUxMKQ0KLQkJcmV0dXJuICgwKTsNCisJCXJldHVybiAoRU5P TUVNKTsNCiANCiAJLyoNCiAJICogQ29uc3RydWN0IG91ciBTSU0gZW50cnku DQpAQCAtMTQwMSw3ICsxNDAxLDcgQEANCiAJYWR2LT5zaW0gPSBjYW1fc2lt X2FsbG9jKGFkdl9hY3Rpb24sIGFkdl9wb2xsLCAiYWR2IiwgYWR2LCBhZHYt PnVuaXQsDQogCQkJCSAxLCBhZHYtPm1heF9vcGVuaW5ncywgZGV2cSk7DQog CWlmIChhZHYtPnNpbSA9PSBOVUxMKQ0KLQkJcmV0dXJuICgwKTsNCisJCXJl dHVybiAoRU5PTUVNKTsNCiANCiAJLyoNCiAJICogUmVnaXN0ZXIgdGhlIGJ1 cy4NCkBAIC0xNDEwLDIxICsxNDEwLDE4IEBADQogCSAqLw0KIAlpZiAoeHB0 X2J1c19yZWdpc3RlcihhZHYtPnNpbSwgMCkgIT0gQ0FNX1NVQ0NFU1MpIHsN CiAJCWNhbV9zaW1fZnJlZShhZHYtPnNpbSwgLypmcmVlIGRldnEqL1RSVUUp Ow0KLQkJcmV0dXJuICgwKTsNCisJCXJldHVybiAoRU5YSU8pOw0KIAl9DQog DQogCWlmICh4cHRfY3JlYXRlX3BhdGgoJmFkdi0+cGF0aCwgLypwZXJpcGgq L05VTEwsIGNhbV9zaW1fcGF0aChhZHYtPnNpbSksDQotCQkJICAgIENBTV9U QVJHRVRfV0lMRENBUkQsIENBTV9MVU5fV0lMRENBUkQpDQotCSAgID09IENB TV9SRVFfQ01QKSB7DQotCQl4cHRfc2V0dXBfY2NiKCZjc2EuY2NiX2gsIGFk di0+cGF0aCwgLypwcmlvcml0eSovNSk7DQotCQljc2EuY2NiX2guZnVuY19j b2RlID0gWFBUX1NBU1lOQ19DQjsNCi0JCWNzYS5ldmVudF9lbmFibGUgPSBB Q19GT1VORF9ERVZJQ0V8QUNfTE9TVF9ERVZJQ0U7DQotCQljc2EuY2FsbGJh Y2sgPSBhZHZhc3luYzsNCi0JCWNzYS5jYWxsYmFja19hcmcgPSBhZHY7DQot CQl4cHRfYWN0aW9uKCh1bmlvbiBjY2IgKikmY3NhKTsNCi0JfQ0KLQlyZXR1 cm4gKDEpOw0KKwkJQ0FNX1RBUkdFVF9XSUxEQ0FSRCwgQ0FNX0xVTl9XSUxE Q0FSRCkgIT0gQ0FNX1JFUV9DTVApDQorCQlyZXR1cm4gKEVOWElPKTsNCiAN Ci1lcnJvcl9leGl0Og0KKwl4cHRfc2V0dXBfY2NiKCZjc2EuY2NiX2gsIGFk di0+cGF0aCwgLypwcmlvcml0eSovNSk7DQorCWNzYS5jY2JfaC5mdW5jX2Nv ZGUgPSBYUFRfU0FTWU5DX0NCOw0KKwljc2EuZXZlbnRfZW5hYmxlID0gQUNf Rk9VTkRfREVWSUNFfEFDX0xPU1RfREVWSUNFOw0KKwljc2EuY2FsbGJhY2sg PSBhZHZhc3luYzsNCisJY3NhLmNhbGxiYWNrX2FyZyA9IGFkdjsNCisJeHB0 X2FjdGlvbigodW5pb24gY2NiICopJmNzYSk7DQogCXJldHVybiAoMCk7DQog fQ0K --0-1518726426-959068326=:86096-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.10005231137570.86096-200000>