Date: Tue, 11 May 2010 11:26:50 +0200 From: Andrea Venturoli <ml@netfence.it> To: Alex Keda <admin@lissyara.su>, freebsd-ports@freebsd.org Subject: Re: php52 and Horde Message-ID: <4BE922DA.8070407@netfence.it> In-Reply-To: <4BE16F81.6050002@lissyara.su> References: <4BE020E3.9080803@netfence.it> <4BE15A97.30402@lissyara.su> <4BE15FAC.4090107@netfence.it> <4BE16F81.6050002@lissyara.su>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/05/10 15:15, Alex Keda wrote:
> 05.05.2010 16:08, Andrea Venturoli пишет:
>> On 05/05/10 13:46, Alex Keda wrote:
>>> 04.05.2010 17:28, Andrea Venturoli пишет:
>>>> In Makefile, there's:
>>>>
>>>> .if ${PHP_VER} == 5
>>>> USE_PHP+= dom
>>>> .else
>>>> USE_PHP+= domxml
>>>> .endif
>>>>
>>>> However, there is no php52-domxml; should php52-dom be used?
>>>>
>>>> Is the makefile wrong? Should it check for ${PHP_VER}==52?
>>>> Or do I need to use some knob?
>>> /usr/ports/textproc/php52-dom
>>
>> Ok, thanks.
>> So, would the following be ok in the above Makefile?
>>
>> .if ${PHP_VER} == 4
>> USE_PHP+= domxml
>> .else
>> USE_PHP+= dom
>> .endif
>>
>> If you can confirm this is fine, I could file a PR with the patch.
> I think, it OK
Well, I was beaten on this :-)
Many thanks to Daniel for patching this port.
bye
av.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BE922DA.8070407>