Date: Wed, 01 Oct 2025 09:49:08 +0200 From: Kristof Provost <kp@FreeBSD.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: ItzBlinkzy <kitey13579@gmail.com>, Kevin Irabor <kevin.irabor04@gmail.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4e7a375804e5 - main - IfAPI: Added missing accessor for if_home_vnet Message-ID: <D992AE7A-1BB5-4630-8A2E-35E0EA6B8782@FreeBSD.org> In-Reply-To: <aNwdPbnDvkBA0mQ1@cell.glebi.us> References: <202509292116.58TLGxWx078766@gitrepo.freebsd.org> <aNwVz6wL5cLbmYqR@cell.glebi.us> <9E63C594-08DD-43CD-BD76-3E9B9E80AA60@FreeBSD.org> <aNwdPbnDvkBA0mQ1@cell.glebi.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On 30 Sep 2025, at 20:11, Gleb Smirnoff wrote: > On Tue, Sep 30, 2025 at 07:51:05PM +0200, Kristof Provost wrote: > K> > The actual question is whether there is a driver that really needs= to access > K> > this field or was this added by the logic that if a field exists i= n struct > K> > ifnet, a function to access it shall exist? > K> > > K> It=E2=80=99s hard to predict what fields will be relevant for out-of= -tree consumers, but it seems reasonable to allow access to this one give= n we already allow the current vnet to be accessed too. > > As we discussed earlier through the last decade, the ifnet is poorly de= signed > and we need a new API. But as that was a heavy weight to lift, that wa= s never > finished. Juniper came with a plan to provide accessors. They would n= ot make > API any better or prettier, but would basically provide binary compatib= ility > for a case when struct ifnet grows or is rearranged but all existing fi= elds > remain! We agreed that this is an interim step towards a better API in = a > future. The Juniper's API shall provide access to minimal set of ifnet= fields > that current drivers use. It should not encourage use of fields that be= long to > the stack, not to the drivers. So, the question is what is the driver t= hat > needs if_home_vnet? Who is maintaining it and what are they going to do= if I > remove if_home_vnet together with if_vmove? > Good questions. I hope Kevin can tell us what his use case for this is, b= ecause it=E2=80=99s always easier to think about these things with specif= ic problems in mind. =E2=80=94 Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D992AE7A-1BB5-4630-8A2E-35E0EA6B8782>