Date: Sun, 20 Sep 2015 10:49:50 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Adrian Chadd <adrian.chadd@gmail.com> Cc: Bruce Simpson <bms@fastmail.net>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Ian Lepore <ian@freebsd.org>, George Neville-Neil <gnn@neville-neil.com>, David Chisnall <theraven@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org> Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys Message-ID: <55FE732E.1010305@selasky.org> In-Reply-To: <20150920042609.GA28414@FreeBSD.org> References: <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org> <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> <55FD23C5.5010008@selasky.org> <64D8263B-1F5D-40E5-994C-479C39B69DC9@neville-neil.com> <1442684369.1224.179.camel@freebsd.org> <55FDA1E7.8050007@fastmail.net> <CAJ-VmoncfCo3ZaP1MY1iLMDZN3piTM_hd0XBJ1xFc=VpySEJsg@mail.gmail.com> <20150920042609.GA28414@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/20/15 06:26, Alexey Dokuchaev wrote: > On Sat, Sep 19, 2015 at 06:38:46PM -0700, Adrian Chadd wrote: >> [...] >> Hans - personally, I think you should've emailed out a review request >> on freebsd-arch@ and put out a request for testers and give a firm date >> that you'll commit it. That makes it all very explicit. > > I agree with general idea of important differentials to be announced on a > mail list. There were probably more than one case when interested people > did not know about a DR because they were not put on a revievers list and > could only comment on the actual commit. > Hi, I've put up a discussion about the FreeBSD's callout subsystem at the coming EuroBSDcon2015 devsummit (approved by Erwin) See: https://wiki.freebsd.org/201510DevSummit Bruce: The code in question is currently so-called dead, already stated several times (davide@) and I see no point to revert right away. Nobody is physically burning because of this change from what I can see. No crashes, no panics. And jch@ wants to test it. I will let some days pass so that the many questions arising in this thread can be properly answered and addressed, because some people are at sleep while others are online and also it is weekend, and some people might be aways from their computers. Alexey+hiren+adrian: You are right about freebsd-arch@. I will put up more stuff at freebsd-arch@ . I thought Phabricator was enough for this change. ian+george+glebius: Being an active kernel developer, growing out of the "USB box" as some have said, it is really frustrating to learn the new non-USB driving rules. I agree with Ian that core should clarify the requirement of pre-commit reviews when not stated in MAINTAINERS for regular FreeBSD kernel developers, to avoid discrimination among the kernel developers. hiren: jch@, wrote in a comment in Phabricator he wanted to approve the change, so it is not fully true that no other kernel developers approved the change, for that matter. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55FE732E.1010305>