Date: Wed, 26 Jan 2011 18:23:26 -0600 From: Brandon Gooch <jamesbrandongooch@gmail.com> To: Bernhard Froehlich <decke@FreeBSD.org> Cc: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>, "freebsd-emulation@freebsd.org" <freebsd-emulation@freebsd.org> Subject: Re: VirtualBox + VIMAGE Message-ID: <C87DB4DA-E68F-418A-88E8-6C0C4A7BD987@gmail.com> In-Reply-To: <44307214e4381602f6381d6a78ded1e2@bluelife.at> References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org> <86tygwy9p0.fsf@kopusha.home.net> <20110126091038.C3489@maildrop.int.zabbadoz.net> <86aainkbhb.fsf@zhuzha.ua1> <20110126141636.D3489@maildrop.int.zabbadoz.net> <86ei7z4aps.fsf@kopusha.home.net> <44307214e4381602f6381d6a78ded1e2@bluelife.at>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 26, 2011, at 5:33 PM, Bernhard Froehlich <decke@FreeBSD.org> wrote: > On Wed, 26 Jan 2011 23:27:27 +0200, Mikolaj Golub wrote: >> On Wed, 26 Jan 2011 14:18:03 +0000 (UTC) Bjoern A. Zeeb wrote: >>=20 >> BAZ> On Wed, 26 Jan 2011, Mikolaj Golub wrote: >>=20 >>>>=20 >>>> On Wed, 26 Jan 2011 09:15:46 +0000 (UTC) Bjoern A. Zeeb wrote: >>>>=20 >>>> BAZ> I think you should wrap the CURVNET changes in __FreeBSD_version >>>> BAZ> checks so that the port, should it run elsewhere or on older >> FreeBSDs >>>> BAZ> (if it runs there) not trouble people having to patch it away. >>>>=20 >>>> BAZ> #if defined(__FreeBSD_version) && __FreeBSD_version >=3D 800500 >>>> BAZ> #endif >>>>=20 >>>> BAZ> might be a save bet. >>>>=20 >>>> Thanks. Something like in the patch below? >>>>=20 >>>> Note, I have not run this version yet. Will test it tonight or tomorrow= . >>=20 >> BAZ> Well, you will need to include <sys/param.h> as well, and that only i= f >> BAZ> you are on FreeBSD so you'll need an extra check for just that I >> BAZ> guess. Not sure how vbox handles the all this in their guts. >>=20 >> The file has already had '#include <sys/param.h>' among other includes. I= t >> just is not seen in the patch. The file is used only for FreeBSD driver s= o >> there is no need in extra check I think. >>=20 >> I have tested this latest version of the patch. It works for me. >=20 > Could someone with a vimage enabled kernel please test bridging with a > stock emulators/virtualbox-ose-kmod port? There was a report that this > causes a crash and it would be good to verify if that is still valid: >=20 > http://lists.freebsd.org/pipermail/freebsd-emulation/2009-November/007055.= html >=20 > --=20 > Bernhard Froehlich > http://www.bluelife.at/ > _______________________________________________ > freebsd-emulation@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-emulation > To unsubscribe, send any mail to "freebsd-emulation-unsubscribe@freebsd.or= g" It still crashes. -Brandon=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C87DB4DA-E68F-418A-88E8-6C0C4A7BD987>