Date: Sun, 18 Aug 2013 15:51:25 -0700 From: Peter Wemm <peter@wemm.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: src-committers@freebsd.org, Peter Wemm <peter@FreeBSD.org>, svn-src-all@freebsd.org, Dimitry Andric <dim@FreeBSD.org>, gabor@freebsd.org, Joel Dahl <joel@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r254273 - in head: . include lib lib/libc/iconv lib/libiconv_compat lib/libkiconv share/mk sys/sys tools/build/mk Message-ID: <52114FED.3010106@wemm.org> In-Reply-To: <20130818224244.GA59141@stack.nl> References: <201308130715.r7D7F1nu076335@svn.freebsd.org> <3887D7C7-D766-40DF-B154-D05768B86AA6@FreeBSD.org> <20130818195304.GA81160@devbox.vnode.local> <20130818224244.GA59141@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 8/18/13 3:42 PM, Jilles Tjoelker wrote: > On Sun, Aug 18, 2013 at 09:53:04PM +0200, Joel Dahl wrote: >> On Sun, Aug 18, 2013 at 12:34:30AM +0200, Dimitry Andric wrote: >>> On Aug 13, 2013, at 09:15, Peter Wemm <peter@FreeBSD.org> wrote: >>>> Author: peter >>>> Date: Tue Aug 13 07:15:01 2013 >>>> New Revision: 254273 >>>> URL: http://svnweb.freebsd.org/changeset/base/254273 > >>>> Log: >>>> The iconv in libc did two things - implement the standard APIs, the GNU >>>> extensions and also tried to be link time compatible with ports libiconv. >>>> This splits that functionality and enables the parts that shouldn't >>>> interfere with the port by default. > >>>> WITH_ICONV (now on by default) - adds iconv.h, iconv_open(3) etc. >>>> WITH_LIBICONV_COMPAT (off by default) adds the libiconv_open etc API, linker >>>> symbols and even a stub libiconv.so.3 that are good enough to be able >>>> to 'pkg delete -f libiconv' on a running system and reasonably expect it >>>> to work. > >>>> I have tortured many machines over the last few days to try and reduce >>>> the possibilities of foot-shooting as much as I can. I've successfully >>>> recompiled to enable and disable the libiconv_compat modes, ports that use >>>> libiconv alongside system iconv etc. If you don't enable the >>>> WITH_LIBICONV_COMPAT switch, they don't share symbol space. > >>>> This is an extension of behavior on other system. iconv(3) is a standard >>>> libc interface and libiconv port expects to be able to run alongside it on >>>> systems that have it. > >>> Unfortunately I expect this will break many ports, when the libiconv >>> port is installed. A simple example is the following: >> <SNIP> > >> It also breaks installworld when /usr/src and /usr/obj are NFS exported >> read-only. > > I think it has to do with share/i18n/csmapper and share/i18n/esdb using > directories as make targets. This apparently causes these files to be > rebuilt at 'make installworld' time, which is always bad but is only > detected when /usr/obj is read-only. > > A hack that works is to enclose the four targets depending on ${SUBDIR} > in .if !make(install) . > > Unfortunately, the Makefiles were written to depend on the directories > as make targets fairly deeply, so a real fix is harder. I was looking at this yesterday, but was tied up with other things. I'll take a look at it today after getting a few other things done. It should be easy enough to replicate by changing /usr/obj to readonly on test systems. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV UTF-8: for when a ' just won\342\200\231t do. <brueffer> ZFS must be the bacon of file systems. <brueffer> "everything's better with ZFS" [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlIRT+0ACgkQFRKuUnJ3cX+eHwCeNmqX55iCjJFkKy/yY1aj4+rI /CYAn3qzTFYfTJFTAfWd3HSQmFFrWjjD =LfC8 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52114FED.3010106>