Date: Tue, 14 Dec 1999 14:28:49 +0200 From: Sheldon Hearn <sheldonh@uunet.co.za> To: "David E. O'Brien" <obrien@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/chown Makefile Message-ID: <41621.945174529@axl.noc.iafrica.com> In-Reply-To: Your message of "Tue, 14 Dec 1999 13:44:51 %2B0200." <40554.945171891@axl.noc.iafrica.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 14 Dec 1999 13:44:51 +0200, Sheldon Hearn wrote:
> Perhaps, but chown isn't needed to get a device node, since chown errors
> are not fatal in MAKEDEV.
By the way, this stopped being true in rev 1.148 of MAKEDEV:
> ----------------------------
> revision 1.148
> date: 1998/01/03 11:53:52; author: jkh; state: Exp; lines: +4 -4
> strengthen mknod().
> Submitted by: bde
> ----------------------------
> mknod() {
> rm -f "$1" || exit 1
> - /sbin/mknod $* || die 2 "/sbin/mknod $* failed"
> - chown root.wheel "$1"
> + /sbin/mknod "$@" || die 2 "/sbin/mknod $@ failed"
> + chown root.wheel "$1" || exit 1
> }
I think the correct fix here would have been to revert that change,
rather than shuffling binaries around unnecessarily.
But as I said before, this isn't a train-smash. It's just something to
consider before people start moving every binary required by MAKEDEV
into /sbin and /bin.
Ciao,
Sheldon.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41621.945174529>