Date: Tue, 12 Apr 2005 17:35:53 +0200 From: Matteo Riondato <rionda@gufi.org> To: Kris Kennaway <kris@obsecurity.org> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c Message-ID: <20050412153553.GC49623@kaiser.sig11.org> In-Reply-To: <20050412145806.GA39557@xor.obsecurity.org> References: <200504120105.j3C15qlZ043565@repoman.freebsd.org> <20050412164157.allpbok7r4wosoco@netchild.homeip.net> <20050412145806.GA39557@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0F1p//8PRICkK4MW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 12, 2005 at 07:58:06AM -0700, Kris Kennaway wrote: > On Tue, Apr 12, 2005 at 04:41:57PM +0200, Alexander Leidinger wrote: > > John Baldwin <jhb@FreeBSD.org> wrote: > >=20 > > > Modified files: > > > usr.sbin/sysinstall config.c > > > Log: > > > Explicitly install linux_base 8 to make sure the right version is > > > installed. > >=20 > > Any ideas how to help sysinstall to get the right one without hardcodin= g it? > > Some hints in the linux_base* ports? > >=20 > > I have changes in the pipeline which add DEFAULT_LINUX_BASE to bsd.port= .mk, > > it will contain a complete dependency (suitable for e.g. "BUILD_DEPENDS= =3D > > ${DEFAULT_LINUX_BASE}"), if sysinstall has access to bsd.port.mk it cou= ld do > > "make -f /path/to/bsd.port.mk -V DEFAULT_LINUX_BASE USE_LINUX=3Dyes" an= d parse > > the output (when the change is committet). >=20 > It doesn't..this will probably just have to be tracked by hand. I would say that if all linux ports depend on the same linux_base port, there wouldn't be more than one linux_base-X package in a -RELEASE CD, so when during installation, we want to add linux_base, we'll always add the right one (because there'll be only one in the CD). The bug appeared on one of the last RELEASEs (see the PR, I seem to remember that it was 5.3-RELEASE) because there were some ports (actually _2_) that depended on linux_base-6, so linux_base-6 was included in the CD and, when the user wanted to add "linux_base", linux_base-6 was chosen instead of linux_base-7 because "6" comes before "7". Please note that the Postfix package depends on a similar hack too (see usr.sbin/sysinstall/config.c, line 993). Best Regards --=20 Rionda aka Matteo Riondato Disinformato per default G.U.F.I. Staff Member (http://www.gufi.org) FreeSBIE Developer (http://www.freesbie.org) --0F1p//8PRICkK4MW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCW+rZ2Mp4pR7Fa+wRAqrKAKCGNGfcmbUzTcLlSUKQfPOm4otTkQCfT6/D H7KIyCQTSYAfmopWZv9+ahg= =7uaV -----END PGP SIGNATURE----- --0F1p//8PRICkK4MW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050412153553.GC49623>