Date: Fri, 17 Aug 2012 08:26:25 -0400 From: John Baldwin <jhb@freebsd.org> To: Randall Stewart <rrs@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r239353 - head/sys/netinet Message-ID: <201208170826.25123.jhb@freebsd.org> In-Reply-To: <201208170551.q7H5pkd1025308@svn.freebsd.org> References: <201208170551.q7H5pkd1025308@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, August 17, 2012 1:51:46 am Randall Stewart wrote: > Author: rrs > Date: Fri Aug 17 05:51:46 2012 > New Revision: 239353 > URL: http://svn.freebsd.org/changeset/base/239353 > > Log: > Ok jhb, lets move the ifa_free() down to the bottom to > assure that *all* tables and such are removed before > we start to free. This won't protect the Hash in ip_input.c > but in theory should protect any other uses that *do* use locks. Eh, this is just a nop unless there is a reference counting bug. Only the last reference would free the memory if the reference count is correct, so this is just adding obfuscation by moving the ifa_free() away from the associated TAILQ_REMOVE(). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208170826.25123.jhb>