Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Oct 2001 23:07:12 -0700
From:      Peter Wemm <peter@wemm.org>
To:        Luigi Rizzo <luigi@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/i386/isa intr_machdep.c 
Message-ID:  <20011014060712.7EF873810@overcee.netplex.com.au>
In-Reply-To: <200110140544.f9E5i8989980@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
Luigi Rizzo wrote:
> luigi       2001/10/13 22:44:08 PDT
> 
>   Modified files:        (Branch: RELENG_4)
>     sys/i386/isa         intr_machdep.c 
>   Log:
>   MFC: export interrupt statistics via sysctl.
>   It would be good to update vmstat to make use of this facility
>   instead of using kmem.

Umm, dont MFC something where there is dissent until it has been resolved!
See attached complaint.

This is *still* a bogus commit!

Problem number 1:  You have only done i386!  
Problem number 2:  This is already exported via sysctl in a MI fashion 
instead of this half hearted bogus duplication.

Please back both of these out, and if you must, then MFC the correct
solution.

======
Subject: Re: cvs commit: src/sys/i386/isa intr_machdep.c
From: Thomas Moestl <tmoestl@gmx.net>
Date: Mon, 8 Oct 2001 00:16:30 +0200
To: Luigi Rizzo <luigi@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org

On Sun, 2001/10/07 at 10:03:56 -0700, Luigi Rizzo wrote:
> luigi       2001/10/07 10:03:56 PDT
> 
>   Modified files:
>     sys/i386/isa         intr_machdep.c 
>   Log:
>   Export interrupt statistics via sysctl.

Uhm, this information is already exported as hw.intrcnt and
hw.intrnames in an MI way. Take a look into usr.bin/systat/vmstat.c in a
-CURRENT to see how they are used.

	- thomas
======

Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011014060712.7EF873810>