Date: Fri, 23 Mar 2012 23:10:38 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Alexander Kabaev <kabaev@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, David Chisnall <theraven@freebsd.org> Subject: Re: svn commit: r233391 - head/contrib/libstdc++/libsupc++ Message-ID: <20120323211038.GR2358@deviant.kiev.zoral.com.ua> In-Reply-To: <20120323164922.0bac354e@kan.dyndns.org> References: <201203232010.q2NKAuIE092217@svn.freebsd.org> <20120323202335.GM2358@deviant.kiev.zoral.com.ua> <20120323164922.0bac354e@kan.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--/qX1VF4Euib7a2dq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 23, 2012 at 04:49:22PM -0400, Alexander Kabaev wrote: > On Fri, 23 Mar 2012 22:23:35 +0200 > Konstantin Belousov <kostikbel@gmail.com> wrote: >=20 > > On Fri, Mar 23, 2012 at 08:10:56PM +0000, David Chisnall wrote: > > > Author: theraven > > > Date: Fri Mar 23 20:10:56 2012 > > > New Revision: 233391 > > > URL: http://svn.freebsd.org/changeset/base/233391 > > >=20 > > > Log: > > > Revert ABI breakage in libsupc++. > > > =20 > > > Unfortunately, the ABI was broken upstream for the 4.2 release, > > > which we imported. We then shipped the broken version for several > > > years and certain ports (e.g. libobjc2) depend on it, so we're > > > stuck with it for now...=20 > > > We should revisit this for 10.0, since we're allowed to break the > > > ABI then, but until then we should keep the ABI we shipped with 8.x > > > and 9.x. > >=20 > > No, you are not allowed to break ABI for symvered libraries, even > > between major releases. >=20 > You are, if we are ditching the system library in favor on one in > ports. Not polite, but I do not see a polite way out of this. The > libraries from ports are effectively shipped with incompatible ABI in > this area for about 4 years now. Luckily for us, breakage does not seem > to be affecting great many applications, as they do not use the changed > interface directly themselves. libobjc2 is the only known at the moment > that is known to be affected. The patch just committed made the base-shipped library incompatible with the ports and manual libstdc++ builds. I think it is wiser to not 'undo the undo', and instead start living with the upstream-approved ABI. For symvered library, it does not make any difference if you break it in 10.0 or 9.1. Also, I think that consumers that depend of the ABI of std::typeinfo can be hacked to understand the layout of vtable. I doubt that there are many users that utilize typeinfo. --/qX1VF4Euib7a2dq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9s5s0ACgkQC3+MBN1Mb4ifqQCeOLY2P7mh1aPhVUeftYHnKIbY Se0AoM7mXiKMh8xhS6XvbNSdyLdVixQj =noti -----END PGP SIGNATURE----- --/qX1VF4Euib7a2dq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120323211038.GR2358>