Date: Wed, 26 Apr 2017 14:23:05 -0700 From: Gleb Smirnoff <glebius@FreeBSD.org> To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r317409 - head/contrib/tcpdump Message-ID: <20170426212305.GF56922@FreeBSD.org> In-Reply-To: <201704251830.v3PIUHdb062645@pdx.rh.CN85.dnsmgr.net> References: <201704251556.v3PFuk5U053547@repo.freebsd.org> <201704251830.v3PIUHdb062645@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Rodney, On Tue, Apr 25, 2017 at 11:30:17AM -0700, Rodney W. Grimes wrote: R> > Author: glebius R> > Date: Tue Apr 25 15:56:46 2017 R> > New Revision: 317409 R> > URL: https://svnweb.freebsd.org/changeset/base/317409 R> > R> > Log: R> > Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it fixes use after free R> R> Lets not use git hashes as references in commit messages, R> it has very little value for someone reading a log of changes R> looking for something. There is no promise that it can be R> found later (github can go Poof). Since I did previous import of tcpdump, I find it very useful to see what exactly has been cherry-picked forward, for the person who will do next import, be it me or someone else. I agree that I should have put the hash into "meta data portion of commit message", not in the description. I will do so next time. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170426212305.GF56922>