Date: Mon, 16 Feb 1998 10:43:37 +1100 From: Bruce Evans <bde@zeta.org.au> To: gibbs@plutotech.com, jkh@FreeBSD.ORG Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/ccd ccd.c Message-ID: <199802152343.KAA19514@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>>jkh 1998/02/15 00:28:28 PST >> >> Modified files: >> sys/dev/ccd ccd.c >> Log: >> Revert part of my previous patch - I don't see the *need* >> to call splbio() from within an interrupt handler here. :-) > >Probably because it is not a real interrupt handler and is not >always called from an splbio() interrupt context. But it was always called from an splbio() context - it is only called from cciodone() which begins with splbio() and finishes with splx(). I think this spl pair is bogus too. cciodone() is only called via the b_iodone callback, and I think b_iodone is only called from biodone() where it is always called in an splbio() context. The call in ccdintr() was even more bogus: - the result was assigned to a nonexistent variable. - there was no matching splx() (this wouldn't have mattered because of two unnecessary layers of splbio()s). "Reverting" part of the previous patch introduced a style bug by removing an empty line. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199802152343.KAA19514>