Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 May 2021 22:44:10 GMT
From:      Vladimir Kondratyev <wulf@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 47791339f0cf - main - ums(4): Start USB xfers on opening of evdev node unconditionally.
Message-ID:  <202105232244.14NMiAni068183@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by wulf:

URL: https://cgit.FreeBSD.org/src/commit/?id=47791339f0cfe3282a6f64b5607047f7bca968ad

commit 47791339f0cfe3282a6f64b5607047f7bca968ad
Author:     Vladimir Kondratyev <wulf@FreeBSD.org>
AuthorDate: 2021-05-23 22:41:17 +0000
Commit:     Vladimir Kondratyev <wulf@FreeBSD.org>
CommitDate: 2021-05-23 22:41:17 +0000

    ums(4): Start USB xfers on opening of evdev node unconditionally.
    
    This fixes inability to start USB xfers in a case when FIFO has been
    already open()-ed but no read() or poll() calls has been issued yet.
    
    MFC after:      2 weeks
    Differential revision:  https://reviews.freebsd.org/D30343
---
 sys/dev/usb/input/ums.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/usb/input/ums.c b/sys/dev/usb/input/ums.c
index b9533221ca8a..cce1831287e4 100644
--- a/sys/dev/usb/input/ums.c
+++ b/sys/dev/usb/input/ums.c
@@ -952,8 +952,8 @@ ums_ev_open(struct evdev_dev *evdev)
 
 	if (sc->sc_fflags == 0) {
 		ums_reset(sc);
-		ums_start_rx(sc);
 	}
+	ums_start_rx(sc);
 
 	return (0);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202105232244.14NMiAni068183>