Date: Fri, 27 Apr 2018 16:49:14 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 227799] editors/emacs editors/emacs-devel: Add devel/liblockfile to LIB_DEPENDS Message-ID: <bug-227799-7788-4IzSHRXKSS@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-227799-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-227799-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227799 Joseph Mingrone <jrm@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrm@freebsd.org --- Comment #1 from Joseph Mingrone <jrm@freebsd.org> --- - This does not cause a build error in poudriere, but if LIB_DEPENDS=3Dliblockfile.so:devel/liblockfile is temporarily added, movema= il does indeed link to liblockfile.so.1, regardless what the MAILUTILS option = is set to. - Also adding ac_cv_lib_lockfile_maillock=3Dno to CONFIGURE_ENV prevents mo= vemail from linking to liblockfile.so.1. The important questions: Is liblockfile required for us? configure.ac contains these two blocks, so I would guess we do not, but am = far from clear. dnl Debian, at least: AC_CHECK_LIB(lockfile, maillock, have_lockfile=3Dyes, have_lockfile=3Dno) if test $have_lockfile =3D yes; then LIBS_MAIL=3D-llockfile AC_DEFINE(HAVE_LIBLOCKFILE, 1, [Define to 1 if you have the 'lockfile' library (-llockfile).]) else # If we have the shared liblockfile, assume we must use it for mail # locking (e.g. Debian). If we couldn't link against liblockfile # (no liblockfile.a installed), ensure that we don't need to. dnl This works for files generally, not just executables. dnl Should we look elsewhere for it? Maybe examine /etc/ld.so.conf? AC_CHECK_PROG(liblockfile, liblockfile.so, yes, no, /usr/lib:/lib:/usr/local/lib:$LD_LIBRARY_PATH) if test $ac_cv_prog_liblockfile =3D yes; then AC_MSG_ERROR([Shared liblockfile found but can't link against it. This probably means that movemail could lose mail. There may be a 'development' package to install containing liblockfile.]) fi fi AC_CHECK_HEADERS_ONCE(maillock.h) AC_SUBST(LIBS_MAIL) ------------ mail_lock=3Dno case "$opsys" in aix4-2) mail_lock=3D"lockf" ;; gnu|freebsd|dragonfly|netbsd|openbsd|darwin|irix6-5) mail_lock=3D"flock" = ;; ## On GNU/Linux systems, both methods are used by various mail programs. ## I assume most people are using newer mailers that have heard of flock. ## Change this if you need to. ## Debian contains a patch which says: "On Debian/GNU/Linux systems, ## configure gets the right answers, and that means *NOT* using flock. ## Using flock is guaranteed to be the wrong thing. See Debian Policy ## for details." and then uses '#ifdef DEBIAN'. Unfortunately the ## Debian maintainer hasn't provided a clean fix for Emacs. ## movemail.c will use 'maillock' when MAILDIR, HAVE_LIBMAIL and ## HAVE_MAILLOCK_H are defined, so the following appears to be the ## correct logic. -- fx ## We must check for HAVE_LIBLOCKFILE too, as movemail does. ## liblockfile is a Free Software replacement for libmail, used on ## Debian systems and elsewhere. -rfr. gnu-*) mail_lock=3D"flock" if test $have_mail =3D yes || test $have_lockfile =3D yes; then test $ac_cv_header_maillock_h =3D yes && mail_lock=3Dno fi ;; --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-227799-7788-4IzSHRXKSS>