Date: Fri, 5 Feb 2010 21:49:52 -0800 From: Neel Natu <neelnatu@gmail.com> To: "M. Warner Losh" <imp@bsdimp.com> Cc: freebsd-mips@freebsd.org Subject: Re: Patch: SMP support for MIPS Message-ID: <dffe84831002052149w6d3afd1re0f5dbca4e5a9a20@mail.gmail.com> In-Reply-To: <20100205.200134.460114267490858629.imp@bsdimp.com> References: <dffe84831002051827r430c7fb6le3c3506bd6d38a03@mail.gmail.com> <20100205.200134.460114267490858629.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Warner, Thanks for looking at this. On Fri, Feb 5, 2010 at 7:01 PM, M. Warner Losh <imp@bsdimp.com> wrote: > In message: <dffe84831002051827r430c7fb6le3c3506bd6d38a03@mail.gmail.com> > =A0 =A0 =A0 =A0 =A0 =A0Neel Natu <neelnatu@gmail.com> writes: > : I have put the diff here for review: > : http://people.freebsd.org/~neel/mips_smp_patch/diff.txt > > + /* > + =A0* XXX > + =A0 * SMP kernels must delay pcpu initialization until after > + =A0 =A0* TLB has been flushed and initialized (see mips_cpu_init()) > + =A0 =A0 */ > + =A0 =A0 if (pcpu_find(0) =3D=3D NULL) > + =A0 =A0 =A0 =A0mips_pcpu0_init(); > + > > The practical upshot of this change is that panic() prior to this > point will fault. =A0Is there some way to avoid this? > That's right. I have this fixed in the updated patch. Please review the changes to pmap.c and machdep.c. http://people.freebsd.org/~neel/mips_smp_patch/diff.txt Briefly, we use an address in KSEG0 for the 'pcpup' until we are ready to transition to a TLB-based pcpu pointer. > The rest of these changes look fairly good. =A0I'll likely comment on a > few nits later that I saw once I have the time to devote to it. > Ok. best Neel > Warner >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dffe84831002052149w6d3afd1re0f5dbca4e5a9a20>