Date: Thu, 27 May 2021 14:47:57 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Kirk McKusick <mckusick@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: f190f9193bc1 - main - Fix fsck_ufs segfaults with gjournal (SU+J) Message-ID: <4faa0667-ca1b-923b-fbae-c97b0b863589@FreeBSD.org> In-Reply-To: <202105212038.14LKcb3U062829@gitrepo.freebsd.org> References: <202105212038.14LKcb3U062829@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/21/21 1:38 PM, Kirk McKusick wrote: > The branch main has been updated by mckusick: > > URL: https://cgit.FreeBSD.org/src/commit/?id=f190f9193bc10a8193c87e0a02fa91400e4eb159 > > commit f190f9193bc10a8193c87e0a02fa91400e4eb159 > Author: Kirk McKusick <mckusick@FreeBSD.org> > AuthorDate: 2021-05-21 20:41:40 +0000 > Commit: Kirk McKusick <mckusick@FreeBSD.org> > CommitDate: 2021-05-21 20:42:37 +0000 > > Fix fsck_ufs segfaults with gjournal (SU+J) > > The segfault was being hit in ckfini() (sbin/fsck_ffs/fsutil.c) > while attempting to traverse the buffer cache to flush dirty buffers. > The tail queue used for the buffer cache was not initialized before > dropping into gjournal_check(). Move the buffer initialization earlier > so that it has been done before calling gjournal_check(). This appears to have broken fsck in at least some use cases. On my rpi I get this error trying to boot: Setting hostid: 0x4ce29432. Starting file system checks: fsck_ufs: Initial malloc(-1515870811) failed fsck_ufs: Initial malloc(-1515870811) failed Automatic file system check failed; help! ERROR: ABORTING BOOT (sending SIGTERM to parent)! The amount being passed to malloc() is malloc junk: (gdb) p/x -1515870811 $1 = 0xa5a5a5a5 The i386 CI jobs in jenkins have been failing with the same error recently as well. I guess this means sblock isn't fully initialized by sblock_init()? At least not enough to set fs_bsize? Hmm, perhaps readsb() is what sets fs_bsize? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4faa0667-ca1b-923b-fbae-c97b0b863589>