Date: Fri, 13 Feb 2004 12:58:04 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Jun Kuriyama <kuriyama@imgsrc.co.jp> Cc: Current <freebsd-current@freebsd.org> Subject: Re: acquiring duplicate lock of same type: "vnode interlock" Message-ID: <20040213125640.D25887@gamplex.bde.org> In-Reply-To: <7mptcjzxbb.wl@black.imgsrc.co.jp> References: <7m65ed2j50.wl@black.imgsrc.co.jp> <20040213060939.Q24610@gamplex.bde.org> <7mptcjzxbb.wl@black.imgsrc.co.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 13 Feb 2004, Jun Kuriyama wrote:
> At Fri, 13 Feb 2004 06:16:21 +1100 (EST),
> Bruce Evans wrote:
> > [about some style bugs :)]
>
> Thanks! Is this better than I committed?
>
> Index: ffs_snapshot.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/ufs/ffs/ffs_snapshot.c,v
> retrieving revision 1.78
> diff -u -r1.78 ffs_snapshot.c
> --- ffs_snapshot.c 12 Feb 2004 08:52:08 -0000 1.78
> +++ ffs_snapshot.c 12 Feb 2004 23:33:07 -0000
> @@ -488,7 +488,9 @@
> VI_LOCK(devvp);
> snaphead = &devvp->v_rdev->si_snapshots;
> if ((xp = TAILQ_FIRST(snaphead)) != NULL) {
> - struct lock *lkp = ITOV(xp)->v_vnlock;
> + struct lock *lkp;
> +
> + lkp = ITOV(xp)->v_vnlock;
> VI_UNLOCK(devvp);
> VI_LOCK(vp);
> vp->v_vnlock = lkp;
> [... similarly]
Yes.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040213125640.D25887>