Date: Sun, 21 Jun 2009 18:26:40 +0200 From: Michael <freebsdusb@bindone.de> To: Rui Paulo <rpaulo@freebsd.org> Cc: freebsd-acpi@freebsd.org Subject: Re: Two new acpi modules, acpi_wmi and acpi_hp Message-ID: <4A3E5F40.4040709@bindone.de> In-Reply-To: <C0DCC4DA-5E4C-46B2-9B84-4EBBC5920B3D@freebsd.org> References: <4A3E1784.2050406@bindone.de> <5AFA3C27-D3DB-48DA-9AF3-9E14D11EEC61@freebsd.org> <C0DCC4DA-5E4C-46B2-9B84-4EBBC5920B3D@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Rui Paulo wrote:
> On 21 Jun 2009, at 15:08, Rui Paulo wrote:
>
>> On 21 Jun 2009, at 12:20, Michael wrote:
>>
>>> Hello,
>>>
>>> I wrote two new acpi modules last year and finally found the time to fix
>>> them, add some missing features and write man pages.
>>
>> Michael, this is great work! I'll review and see if we can ship it
>> with 8.0!
>
> Michael, this looks good, but there are two style nits that we need to fix.
> * we should try not going over the 80 column mark
> * add a empty new line before every return
>
> If you could send me a new patch for 8.0 with these fixes, I'll commit
> it (unless someone else has objections).
>
> Regards,
> --
> Rui Paulo
>
Hi Rui,
hmm style(9) doesn't say anything about columns or return statements in
this context (maybe it should be updated?!?).
Anyway, when saying adding an empty line before every return statement,
do you also mean conditional return statements:
So e.g.
int func()
{
int a;
if (!a)
return 0;
return 1;
}
Should be:
int func()
{
int a;
if (!a)
return 0;
return 1;
}
or
int func()
{
int a;
if (!a) {
return 0;
}
return 1;
}
??
Thanks
Michael
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A3E5F40.4040709>