Date: Tue, 7 Mar 2023 06:33:06 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Koichiro Iwao <meta@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d69b20995dec - main - security/softether5: add DEBUG option Message-ID: <ZAbaohnFprpyO4hB@FreeBSD.org> In-Reply-To: <20230307001606.j7vhypsfrohkz62s@icepick.vmeta.jp> References: <202303060432.3264Wbtc041269@gitrepo.freebsd.org> <ZAWLnDz5cb4vIR/j@FreeBSD.org> <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> <20230306195254.n3gxqbchj5voyypw@aching.in.mat.cc> <20230306195501.ithqt45oxm2z2mgn@aching.in.mat.cc> <20230307001606.j7vhypsfrohkz62s@icepick.vmeta.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 07, 2023 at 09:16:06AM +0900, Koichiro Iwao wrote: > On Mon, Mar 06, 2023 at 08:55:01PM +0100, Mathieu Arnold wrote: > > > ... > > > WITH_DEBUG is a global user facing knob, it must never be activated > > > via options. > > > > Sorry, bad wording, it must never be set in any Makefile, wether > > options, flavor, or whatever. It is not a port setting, that one sets > > in a Makefile, it is a user setting that one sets in make.conf. > > Understood. Other ports which have DEBUG option mostly don't set > WITH_DEBUG but just add something like --enable-debug to *_ARGS. This > kind of DEBUG options are allowed, right (ex. lang/php8[012])? No, it's not, PHP ports do it wrong. Correct way is: .if defined(WITH_DEBUG) CONFIGURE_ARGS+= --enable-debug .endif ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZAbaohnFprpyO4hB>