Date: Tue, 4 Apr 2017 20:56:23 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Conrad Meyer <cem@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316492 - in head/usr.bin/grep: . regex Message-ID: <B9C5AC3B-1775-4D5D-ADA7-C6CE091F32F5@FreeBSD.org> In-Reply-To: <4D675D2F-7D6F-4AF2-AE10-5DF19D4158D0@gmail.com> References: <201704041608.v34G8qSo055328@repo.freebsd.org> <4D675D2F-7D6F-4AF2-AE10-5DF19D4158D0@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 4 Apr 2017, at 19:14, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > >> On Apr 4, 2017, at 09:08, Conrad Meyer <cem@FreeBSD.org> wrote: >> >> Author: cem >> Date: Tue Apr 4 16:08:51 2017 >> New Revision: 316492 >> URL: https://svnweb.freebsd.org/changeset/base/316492 >> >> Log: >> bsdgrep(1): Rip out "xmalloc" bits >> >> xmalloc was a debug malloc implementation, but the x{malloc,calloc,free} >> functions default to calling the malloc(3) equivalents. >> >> Instead of relying on this malloc shim, we can devise better ways to debug >> malloc issues that aren't misleading upon initial inspection. (I.e., using >> jemalloc's various built-in debugging capabilities.) >> >> Submitted by: Kyle Evans <kevans91 at ksu.edu> >> Reviewed by: emaste, cem >> Differential Revision: https://reviews.freebsd.org/D10269 >> >> Deleted: >> head/usr.bin/grep/regex/xmalloc.c >> head/usr.bin/grep/regex/xmalloc.h >> Modified: >> head/usr.bin/grep/Makefile >> head/usr.bin/grep/regex/fastmatch.c >> head/usr.bin/grep/regex/tre-compile.c >> head/usr.bin/grep/regex/tre-fastmatch.c > > Where did xmalloc.c originate from? GNU. Almost all software from the GNU project relies on malloc wrappers which abort the program on allocation failures. > I can’t find any references to it in OpenBSD’s grep implementation (I’m pretty sure this copy of grep started there). Not sure, they must have disliked the GNUisms too, probably. :) -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAljj7F8ACgkQsF6jCi4glqOefwCff5XvCW749M/S42MNQ8lU9ILU J2MAoKKi91o9dC2iWqrssVD4K+fkldK+ =7hUw -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B9C5AC3B-1775-4D5D-ADA7-C6CE091F32F5>