Date: Thu, 25 Oct 2018 00:04:20 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Warner Losh <imp@bsdimp.com>, Konstantin Belousov <kostikbel@gmail.com> Cc: Toomas Soome <tsoome@me.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339673 - head/stand/libsa Message-ID: <9ec336bd-e45d-4d0f-58de-19dd8eed0a09@yandex.ru> In-Reply-To: <CANCZdfoJdb%2B=7PqCopvTUA9wKS8D=9WzHu23X4q1wsL6ZQKidQ@mail.gmail.com> References: <201810232311.w9NNBc4n031783@repo.freebsd.org> <4893BA79-ED08-401E-9AFD-4A9BD71A076C@me.com> <20181024150107.GE5335@kib.kiev.ua> <CANCZdfoJdb%2B=7PqCopvTUA9wKS8D=9WzHu23X4q1wsL6ZQKidQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --P5U4jVKQ45paAtvGPWvmYsnnr53O3L4CD Content-Type: multipart/mixed; boundary="xp9uGLQZgYTcrylJfLwXXkfRUj9lCm88N"; protected-headers="v1" From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Warner Losh <imp@bsdimp.com>, Konstantin Belousov <kostikbel@gmail.com> Cc: Toomas Soome <tsoome@me.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <9ec336bd-e45d-4d0f-58de-19dd8eed0a09@yandex.ru> Subject: Re: svn commit: r339673 - head/stand/libsa References: <201810232311.w9NNBc4n031783@repo.freebsd.org> <4893BA79-ED08-401E-9AFD-4A9BD71A076C@me.com> <20181024150107.GE5335@kib.kiev.ua> <CANCZdfoJdb+=7PqCopvTUA9wKS8D=9WzHu23X4q1wsL6ZQKidQ@mail.gmail.com> In-Reply-To: <CANCZdfoJdb+=7PqCopvTUA9wKS8D=9WzHu23X4q1wsL6ZQKidQ@mail.gmail.com> --xp9uGLQZgYTcrylJfLwXXkfRUj9lCm88N Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 24.10.2018 18:08, Warner Losh wrote: > > >=C2=A0 Note that libstand also provides crc32.c which seems to b= e unused. > > > > It is used by part.c, by the GPT functions. However, if we have > non-optional compile case for crc32, it is not hard to update part.= c > and drop the unused instance. >=20 > My point is that static library cannot usefully contain two files > with the > same name.=C2=A0 I believe that libstand.a provides crc32.o compile= d from the > contrib/zlib location. >=20 >=20 > Yes. It does. AFAIR, there was some PR that asks for adding CRC32 support to tha loader commands. Maybe it is time to add something that can be used by all consumers. https://bugs.freebsd.org/bugzilla/buglist.cgi?list_id=3D256921&query_form= at=3Dadvanced&short_desc=3Dcrc32&short_desc_type=3Dallwordssubstr --=20 WBR, Andrey V. Elsukov --xp9uGLQZgYTcrylJfLwXXkfRUj9lCm88N-- --P5U4jVKQ45paAtvGPWvmYsnnr53O3L4CD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAlvQ3lQACgkQAcXqBBDI oXqVFQf/XFkkmemE/1tQ/RbaB2mOTcxVuWwpPxkHso+9OdaVm0BucIv/rvFY4gNz kCVfIEmn5olEhfDwuYN/Z0aY+FWn3bgFyfOjeqqis3xXL8teIB77C9U3nLgcahYo JpzFEB633kRuolggXx+j190X5EZPe4Rc+YE5jSXw45jcedE0ikQRkn0ZsEPL01pO PPnUnLi9G/Fg9nAdBSxYkteGj5tW6EMMFpTegukgFdUDpWEeIkeW9gENZcRYwGw0 DvtO2o3ccC2qzQBRMIxKF9OCjzoJOYaXOPXGL6YWKNuPbjylJv/O+InWVrfZx+/i cJ2uIwWYDNLSBVrx1m8rPmCKvx5beQ== =083y -----END PGP SIGNATURE----- --P5U4jVKQ45paAtvGPWvmYsnnr53O3L4CD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9ec336bd-e45d-4d0f-58de-19dd8eed0a09>