Date: Thu, 26 Jun 2025 21:29:30 GMT From: Mark Johnston <markj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 6bdc9743d8f8 - main - fibs_test: Mark same_ip_multiple_ifaces_fib0 as expected to fail Message-ID: <202506262129.55QLTUgb049532@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=6bdc9743d8f8c9727e5101d6cb6f2a85a13c5acb commit 6bdc9743d8f8c9727e5101d6cb6f2a85a13c5acb Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2025-06-26 21:19:14 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2025-06-26 21:27:57 +0000 fibs_test: Mark same_ip_multiple_ifaces_fib0 as expected to fail The test relies on being able to assign the same interface address to two different tap interfaces; it then removes one of the addresses, which at one point would trigger a kernel panic. Since 361a8395f0b0 it is not possible to assign an address multiple times this way, so the test fails. Just mark it as expected to fail for now: if the kernel's behaviour here changes again, this test might be a useful seatbelt. MFC after: 2 weeks --- tests/sys/netinet/fibs_test.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/sys/netinet/fibs_test.sh b/tests/sys/netinet/fibs_test.sh index 5fe8f7d87641..2d0b63f8e30a 100644 --- a/tests/sys/netinet/fibs_test.sh +++ b/tests/sys/netinet/fibs_test.sh @@ -320,6 +320,9 @@ same_ip_multiple_ifaces_fib0_body() # Setup the interfaces, then remove one alias. It should not panic. setup_tap 0 inet ${ADDR} ${MASK0} TAP0=${TAP} + # After commit 361a8395f0b0e6f254fd138798232529679d99f6 it became + # an error to assign the same interface address twice. + atf_expect_fail "The test results in an ifconfig error and thus spuriously fails" setup_tap 0 inet ${ADDR} ${MASK1} TAP1=${TAP} ifconfig ${TAP1} -alias ${ADDR}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202506262129.55QLTUgb049532>