Date: Fri, 9 Apr 2021 21:57:55 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Konstantin Belousov <kib@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 06d8a116bd6b - main - libc: add _get_tp() private function Message-ID: <4BDA2D21-D5D0-4EC2-B6F7-B99260D046E0@freebsd.org> In-Reply-To: <202104092047.139KlBo3071549@gitrepo.freebsd.org> References: <202104092047.139KlBo3071549@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 Apr 2021, at 21:47, Konstantin Belousov <kib@FreeBSD.org> wrote: >=20 > The branch main has been updated by kib: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D06d8a116bd6b6f70b8aedc6a6a2c4085= c53f63ac >=20 > commit 06d8a116bd6b6f70b8aedc6a6a2c4085c53f63ac > Author: Konstantin Belousov <kib@FreeBSD.org> > AuthorDate: 2021-04-05 03:30:35 +0000 > Commit: Konstantin Belousov <kib@FreeBSD.org> > CommitDate: 2021-04-09 20:46:24 +0000 >=20 > libc: add _get_tp() private function >=20 > which returns pointer to tcb This feels like it should be static inline in a header. Also we already = have _tcb_get in pthread_md.h that should be entirely equivalent, and _libc_get_static_tls_base that=E2=80=99s basically the same again but = with an optional offset. Can we do something to unify all the inline asm into one place = per architecture rather than growing yet more copies of the same thing? Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BDA2D21-D5D0-4EC2-B6F7-B99260D046E0>