Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Mar 2018 16:32:28 -0500
From:      Kyle Evans <kevans@freebsd.org>
To:        Jeff Roberson <jeff@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r331018 - head/sys/vm
Message-ID:  <CACNAnaFmOdN9q51%2BKB%2BBvef71Jizmr8EFCqPtSw-XOL3Y7ZfGg@mail.gmail.com>
In-Reply-To: <201803151923.w2FJN7G7064582@repo.freebsd.org>
References:  <201803151923.w2FJN7G7064582@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 15, 2018 at 2:23 PM, Jeff Roberson <jeff@freebsd.org> wrote:
> Author: jeff
> Date: Thu Mar 15 19:23:07 2018
> New Revision: 331018
> URL: https://svnweb.freebsd.org/changeset/base/331018
>
> Log:
>   Eliminate pageout wakeup races.  Take another step towards lockless
>   vmd_free_count manipulation.  Reduce the scope of the free lock by
>   using a pageout lock to synchronize sleep and wakeup.  Only trigger
>   the pageout daemon on transitions between states.  Drive all wakeup
>   operations directly as side-effects from freeing memory rather than
>   requiring an additional function call.
>
>   Reviewed by:  markj, kib
>   Tested by:    pho
>   Sponsored by: Netflix, Dell/EMC Isilon
>   Differential Revision:        https://reviews.freebsd.org/D14612
>

Hey,

Just a heads up: this broke the GCC builds [1] with the following (excerpt):

20:00:47 /usr/src/sys/vm/vm_pagequeue.h:249: warning: redundant
redeclaration of 'pagedaemon_wakeup' [-Wredundant-decls]
20:00:47 /usr/src/sys/vm/vm_pageout.h:98: warning: previous
declaration of 'pagedaemon_wakeup' was here

Thanks,

Kyle Evans

[1] https://ci.freebsd.org/job/FreeBSD-head-mips64-build/1108/console



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFmOdN9q51%2BKB%2BBvef71Jizmr8EFCqPtSw-XOL3Y7ZfGg>