Date: Wed, 07 Jan 2015 18:54:57 +0000 (GMT) From: Rui Paulo <rpaulo@me.com> To: Hans Petter Selasky <hselasky@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r276407 - head/sys/dev/usb/controller Message-ID: <03ad1e28-01a1-476b-a0cb-fb827f18df81@me.com>
next in thread | raw e-mail | index | archive | help
On Dec 30, 2014, at 01:20 AM, Hans Petter Selasky <hselasky@FreeBSD.org> w= rote:=0A=0AAuthor: hselasky=0ADate: Tue Dec 30 09:20:29 2014=0ANew Revisio= n: 276407=0AURL: https://svnweb.freebsd.org/changeset/base/276407=0A=0ALog= :=0AAllow systems having a page size greater than 4K to use fewer=0Ascatte= r-gather XHCI TRB entries for its payload data. The XHCI=0Acontroller can = handle at least 65536 bytes per scatter-gather list=0Aentry.=0A=0AMFC afte= r: =C2=A01 week=0ASuggested by: =C2=A0Kohji Okuno <okuno.kohji@jp.panasoni= c.com>=0A=0AModified:=0Ahead/sys/dev/usb/controller/xhci.h=0A=0AModified: = head/sys/dev/usb/controller/xhci.h=0A=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A--- head/sys/dev/usb/contr= oller/xhci.h =C2=A0Tue Dec 30 08:50:50 2014 =C2=A0 =C2=A0(r276406)=0A+++ h= ead/sys/dev/usb/controller/xhci.h =C2=A0Tue Dec 30 09:20:29 2014 =C2=A0 =C2= =A0(r276407)=0A@@ -320,11 +320,23 @@ struct xhci_dev_endpoint_trbs {=0A=C2= =A0 XHCI_MAX_TRANSFERS) + XHCI_MAX_STREAMS];=0A};=0A=0A-#define =C2=A0 =C2= =A0XHCI_TD_PAGE_NBUF =C2=A0 =C2=A0 =C2=A017 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* = units, room enough for 64Kbytes */=0A-#define =C2=A0 =C2=A0 =C2=A0XHCI_TD_= PAGE_SIZE =C2=A04096 =C2=A0 =C2=A0/* bytes */=0A-#define =C2=A0XHCI_TD_PAY= LOAD_MAX =C2=A0 =C2=A0 =C2=A0(XHCI_TD_PAGE_SIZE * (XHCI_TD_PAGE_NBUF - 1))= =0A+#if (USB_PAGE_SIZE < 4096)=0A+#error "The XHCI driver needs a pagesize= above 4K"=0A+#endif=0A=0AThis error string is misleading: it should read = "page size greater or equal to 4096 bytes".=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?03ad1e28-01a1-476b-a0cb-fb827f18df81>