Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 10 Apr 2015 13:20:32 +0000 (UTC)
From:      Ian Lepore <ian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r281367 - head/sys/dev/usb/serial
Message-ID:  <201504101320.t3ADKWu1096167@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: ian
Date: Fri Apr 10 13:20:31 2015
New Revision: 281367
URL: https://svnweb.freebsd.org/changeset/base/281367

Log:
  The "get latency" and "get bitmode" device commands are read operations,
  not writes.

Modified:
  head/sys/dev/usb/serial/uftdi.c

Modified: head/sys/dev/usb/serial/uftdi.c
==============================================================================
--- head/sys/dev/usb/serial/uftdi.c	Fri Apr 10 10:23:52 2015	(r281366)
+++ head/sys/dev/usb/serial/uftdi.c	Fri Apr 10 13:20:31 2015	(r281367)
@@ -1701,7 +1701,7 @@ uftdi_get_bitmode(struct ucom_softc *uco
 	struct uftdi_softc *sc = ucom->sc_parent;
 	usb_device_request_t req;
 
-	req.bmRequestType = UT_WRITE_VENDOR_DEVICE;
+	req.bmRequestType = UT_READ_VENDOR_DEVICE;
 	req.bRequest = FTDI_SIO_GET_BITMODE;
 
 	USETW(req.wIndex, sc->sc_ucom.sc_portno);
@@ -1738,7 +1738,7 @@ uftdi_get_latency(struct ucom_softc *uco
 	usb_error_t err;
 	uint8_t buf;
 
-	req.bmRequestType = UT_WRITE_VENDOR_DEVICE;
+	req.bmRequestType = UT_READ_VENDOR_DEVICE;
 	req.bRequest = FTDI_SIO_GET_LATENCY;
 
 	USETW(req.wIndex, sc->sc_ucom.sc_portno);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201504101320.t3ADKWu1096167>