Date: Fri, 13 Feb 2015 14:25:23 -0800 From: hiren panchasara <hiren@strugglingcoder.info> To: Peter Holm <peter@holm.cc> Cc: svn-src-head@freebsd.org, Randall Stewart <rrs@FreeBSD.org>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r278623 - head/sys/kern Message-ID: <20150213222523.GD19044@strugglingcoder.info> In-Reply-To: <20150213191106.GA30783@x2.osted.lan> References: <201502121331.t1CDV9jR086269@svn.freebsd.org> <20150213182901.GC19044@strugglingcoder.info> <20150213191106.GA30783@x2.osted.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 02/13/15 at 08:11P, Peter Holm wrote: > On Fri, Feb 13, 2015 at 10:29:01AM -0800, hiren panchasara wrote: > > On 02/12/15 at 01:31P, Randall Stewart wrote: > > > Author: rrs > > > Date: Thu Feb 12 13:31:08 2015 > > > New Revision: 278623 > > > URL: https://svnweb.freebsd.org/changeset/base/278623 > > > > > > Log: > > > This fixes a bug I in-advertantly inserted when I updated the callout > > > code in my last commit. The cc_exec_next is used to track the next > > > when a direct call is being made from callout. It is *never* used > > > in the in-direct method. When macro-izing I made it so that it > > > would separate out direct/vs/non-direct. This is incorrect and can > > > cause panics as Peter Holm has found for me (Thanks so much Peter for > > > all your help in this). What this change does is restore that behavior > > > but also get rid of the cc_next from the array and instead make it > > > be part of the base callout structure. This way no one else will get > > > confused since we will never use it for non-direct. > > > > > > Reviewed by: Peter Holm and more importantly tested by him ;-) > > > MFC after: 3 days. > > > Sponsored by: Netflix Inc. > > > > Can I get more info/backtraces for the panic, please? > > > > Sure. > > These two panics were seen: > > http://people.freebsd.org/~pho/stress/log/rrs004.txt > http://people.freebsd.org/~pho/stress/log/rrs005.txt Thank you, Peter. cheers Hiren [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJU3nnTXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lwnoIAIIEExjvNO8cBGXP6h+KmODm uhOTSbSLiSFwdNsZCySIWRo/HAJ0rwACKvP+1hp4YHzQfpNt8LXyELVa6hGN+Dtj 1ieRG1X0Prx7mvFjEzXlOpsDiCJ5UCs+MSn8HdJttXCRiOsCqmsdzlxRMyolahHe 3E1seziYoGoNs+0Hic2zGzso+hFDzTGtWqIMBfZPJKkRVB4tsMdYTUbMqRInpDNt jaryLhi5FvfDpyGqUMHDQB1VbWJjq9dzxK9RjAbZKdSasZOeaBV0AnvGoCenmAve rEhFYzdLNw6YSf9IjDCN2EdXYonhFk2BQapNlLSVJjVKgKI8g6YOAzOq6G2AH7M= =R9L8 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150213222523.GD19044>