Date: Mon, 17 Jun 2024 14:14:59 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 279816] Avoid defaulting to GH when USE_GITLAB and USE_GITHUB=nodefault is set Message-ID: <bug-279816-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D279816 Bug ID: 279816 Summary: Avoid defaulting to GH when USE_GITLAB and USE_GITHUB=3Dnodefault is set Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: brd@FreeBSD.org CC: ports-bugs@FreeBSD.org Created attachment 251525 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D251525&action= =3Dedit patch When debugging some fetch failures I noticed that my port was always trying= to fetch from github instead of gitlab when USE_GITLAB and USE_GITHUB=3Dnodefa= ult is set. This appears to be because we check that MASTER_SITES is empty before USE_GITLAB has a chance to be run. The attached patch modifies the logic so that USE_GITHUB=3Dnodefault is che= cked even if MASTER_SITES is empty so that USE_GITLAB can populate it later. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-279816-7788>