Date: Thu, 10 Oct 2013 18:37:46 +1030 From: "Daniel O'Connor" <doconnor@gsoft.com.au> To: Hans Petter Selasky <hps@bitfrost.no> Cc: freebsd-usb@freebsd.org Subject: Re: USB config SX lock deadlock Message-ID: <2F3BD963-9839-49E5-A67E-E12DE3004009@gsoft.com.au> In-Reply-To: <52565BB1.8070506@bitfrost.no> References: <9783900F-08A1-41FB-81B8-3C9809B82521@gsoft.com.au> <52553000.2010003@bitfrost.no> <A2C6A9D3-1595-41D2-A5C6-B544A3E40058@gsoft.com.au> <52554855.6030404@bitfrost.no> <FFD6BC71-0CAC-41AE-9450-6549F4B0E9C5@gsoft.com.au> <52564953.8080707@bitfrost.no> <7610BC59-ED91-4807-B145-7F7DD2C725E9@gsoft.com.au> <52565BB1.8070506@bitfrost.no>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 10/10/2013, at 18:18, Hans Petter Selasky <hps@bitfrost.no> wrote: > If you use synchronous USB control requests, then those should always error out. Yes it is synchronous (uses usbd_do_request_flags). >> The usb_fifo_* code handles all wakeups so I am not sure. > > The usb_fifo code only will only do refcounting. If you do USB control requests, you should use the f_ioctl_post, callback, because the f_ioctl callback does not protect against attach and detach or the enumeration thread running. Sorry, I misspoke earlier :( The usb_fifo code is only used for the RS485 and high speed data bus, the other (low speed configuration bus) is done using ioctl -> usbd_do_request(UT_*_VENDOR_DEVICE). I will see about cranking up the debug level and trying to provoke a failure on the bench. -- Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iD8DBQFSVmBS5ZPcIHs/zowRAswaAJ9Q0FcqRP+kaIsptlsK9x7snHEH5QCfYq7r lQlCklXcC8rrLhBLCCR1HOE= =mPKY -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2F3BD963-9839-49E5-A67E-E12DE3004009>