Date: Wed, 22 May 2019 14:06:18 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: John Baldwin <jhb@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Renato Botelho <garga@freebsd.org>, Brad Davis <brd@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347961 - head Message-ID: <201905222106.x4ML6Idr086719@gndrsh.dnsmgr.net> In-Reply-To: <a21183c9-dcfe-7dc0-3fb4-1380e4a22f38@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 5/22/19 5:48 AM, Alexey Dokuchaev wrote: > > On Wed, May 22, 2019 at 09:42:29AM -0300, Renato Botelho wrote: > >> On 18/05/19 16:36, Brad Davis wrote: > >>> New Revision: 347961 > >>> URL: https://svnweb.freebsd.org/changeset/base/347961 > >>> > >>> Log: > >>> Add note to UPDATING for users of mergemaster after the move of > >>> master.passwd and group in r347638. > >>> > >>> Approved by: allanjude (mentor) > >>> > >>> Modified: > >>> head/UPDATING > >>> > >>> +20190517: > >>> + For users of mergemaster, after recent changes to locations of > >>> + master.passwd and group in the source tree mergemaster needs to be > >>> + updated. Before running `mergemaster -p', cd to usr.sbin/mergemaster > >>> + and run `make install'. > >>> + > >> > >> etcupdate is installing group and master.passwd to /lib/libc/gen. It > >> seems wrong. > >> > >> root@x230:/usr/src # etcupdate -p > >> A /lib/libc/gen/group > >> A /lib/libc/gen/master.passwd > > > > *facepalm* > > > > Let me ask again: why these files were moved out of their perfectly > > (and likely the only) reasonable location (etc/) under some cryptic > > libc/gen/ which not only makes little sense per se, but also breaks > > mergemaster(8) and similar tools? > > Because bmake doesn't support .PATH? Oh wait... I spoke long ago when this whole "rip etc/ apart" started, and objected repeatedly and was shot down. I even asked for a "complete plan" and was more or less told this is by design of pkg base. Let me speak to "by design", the BSD source tree is, by design, to reflect the installed location of a file with very rare exception to that design. The .mk system by design is written with this assumption in mind as well. The above artifact is by that design. Attempts to alter such by design behavior has problems, some of which are now, repeatedly showing there ugly head. .PATH could of easily been used, as well as cd ${SRCTOP}/etc && make FOOCONF to implement exactly what was done without ANY file moves. Oh, wait that was pointed out, I belive twice, maybe 3 times, and by some experts on the .mk system as well. sjg (bmake maintainr) and bdrewery (one of our .mk system experts) have both pushed back on these changes. Good luck with supporting this so not by design package system if it requires this to be operable. Also good luck maintaining any of the ${DESTDIR}/etc files as now no one knows how to find them in the source tree. > John Baldwin -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905222106.x4ML6Idr086719>