Date: Sat, 26 Oct 2013 16:50:01 GMT From: Sergey Kandaurov <pluknet@gmail.com> To: freebsd-doc@FreeBSD.org Subject: Re: docs/183333: Misnamed constant in bpf(4) Message-ID: <201310261650.r9QGo1RZ093233@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR docs/183333; it has been noted by GNATS. From: Sergey Kandaurov <pluknet@gmail.com> To: Mats Erik Andersson <bsd@gisladisker.se> Cc: bug-followup@FreeBSD.org Subject: Re: docs/183333: Misnamed constant in bpf(4) Date: Sat, 26 Oct 2013 20:49:50 +0400 The bpf(4) documentation states that the example is taken from the Reverse ARP Daemon. rarpd is tightly coupled with BPF. This macro is actually used there mapped to ARPOP_REVREQUEST. From rarpd code snippet's p.o.v. this EXAMPLES is correct, but is not compilable as is without adding this mapping there. The REVARP_REQUEST localism is probably came from SunOS? (and RFC1931). This macro does not exist in net/if_arp.h (in any BSD except Solaris) and is/was probably used for source compatibility with SunOS. The ARPOP_REVREQUEST macro sits there since 1992 (4.4BSD). SunOS took if_arp.h from UCB on 1/24/86 and added REVARP_REQUEST on its own. It seems to not have ARPOP_REVREQUEST. wpaul modified rarpd.c in r19859 to use REVARP_REQUEST (it was ARPOP_REVREQUEST there originally r6823). The bpf(4) man page came in with r5882 from 1.1.5, and it was REVARP_REQUEST there. It was REVARP_REQUEST in rarpd as found in 4.3BSD-UWisc copyrighted by Sun Micro dated 86/02/05 which is before 1992. -- wbr, pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310261650.r9QGo1RZ093233>