Date: Sun, 10 Oct 2004 01:37:10 +0400 From: Gleb Smirnoff <glebius@freebsd.org> To: Sam Leffler <sam@errno.com> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys mbuf.h src/sys/kern uipc_mbuf2.c src/share/man/man9 mbuf_tags.9 Message-ID: <20041009213710.GB8922@cell.sick.ru> In-Reply-To: <4168009A.303@errno.com> References: <200410091325.i99DPK00097724@repoman.freebsd.org> <4168009A.303@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 09, 2004 at 08:15:38AM -0700, Sam Leffler wrote: S> I don't recall your showing me the change to remove m_tag_free in S> mbuf.h. These change the semantics of calling m_tag_free--before they S> called the method pointer, but now they explicitly call the static S> function which is typically not what is desired. Your original request S> was solely to expose the _m_tag_free function so that code could access S> it; but you've done far more than that with this commit. I believe you S> should revert the API change. Sam, I have searched all src/sys for m_tag_free() users. All of them call m_tag_free() on an mtag that was just allocated several lines before. This means, that nothing have changed for them. Yes, I have changed the API, but nothing is affected. And it is important, that now API is in accordance with OpenBSD's API, from where mtags came from. This will make porting of things easier. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041009213710.GB8922>